Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v10.4.0 proposal #21167

Merged
merged 93 commits into from
Jun 6, 2018
Merged

v10.4.0 proposal #21167

merged 93 commits into from
Jun 6, 2018

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Jun 6, 2018

2018-06-06, Version 10.4.0 (Current), @MylesBorins

Notable Changes

  • deps:
  • update V8 to 6.7.288.43 (Michaël Zasso) #19989
  • stream:
    • ensure Stream.pipeline re-throws errors without callback (Blaine Bublitz) #20437

Commits

  • [9ada68b186] - benchmark: refactor benchmark/assert/throws.js (Rich Trott) #21030
  • [b8470b929f] - benchmark: refactor deepequal-typedarrays (Rich Trott) #21030
  • [686587ba1a] - benchmark: refactor deepequal-set (Rich Trott) #21030
  • [56c67595db] - benchmark: refactor prims-and-objs-big-loop (Rich Trott) #21030
  • [6fbb00e887] - benchmark: refactor prims-and-objs-big-array-set (Rich Trott) #21030
  • [4d714421e9] - benchmark: refactor deepequal-object (Rich Trott) #21030
  • [9b0fc59723] - benchmark: refactor deepequal-map (Rich Trott) #21030
  • [90d86586d2] - benchmark: refactor deepequal-buffer (Rich Trott) #21030
  • [be249d9eb5] - benchmark: fix "comparisons"' typo (Yuta Hiroto) #21085
  • [bad3c92124] - (SEMVER-MINOR) build: reset embedder string to "-node.0" (Michaël Zasso) #19989
  • [35d6661973] - deps: cherry-pick 6989b3f6d7 from V8 upstream (Timothy Gu) #20826
  • [4e788dc2f5] - (SEMVER-MINOR) deps: backport 91ddb65d from upstream V8 (Maya Lekova) #19989
  • [fb2686148e] - deps: cherry-pick ff0a9793334 from upstream V8 (Anna Henningsen) #20719
  • [40c8bbecec] - deps: cherry-pick 23652c5f from upstream V8 (Eugene Ostroukhov) #20608
  • [a7aff77a97] - (SEMVER-MINOR) deps: cherry-pick 39d546a from upstream V8 (Gus Caplan) #20016
  • [fed1d18054] - (SEMVER-MINOR) deps: update v8.gyp (Michaël Zasso) #19989
  • [da8ad4aba9] - (SEMVER-MINOR) deps: update V8 to 6.7.288.43 (Michaël Zasso) #19989
  • [2c671ab2fd] - doc: fix typo in addons.md (Rich Trott) #21137
  • [e2a792866c] - doc: add offboarding doc (Rich Trott) #21103
  • [15aa3c1046] - doc: add notable-change to onboarding.md exercise (Rich Trott) #21040
  • [29c35bd0de] - doc: remove link prediction from STYLE_GUIDE.md (Rich Trott) #21031
  • [261ef1d242] - doc: remove POST_STATUS_TO_PR from onboarding.md (Rich Trott) #21042
  • [2edf1728a0] - doc: fix typos on e.g. abbreviations (Rich Trott) #21045
  • [b1f0907416] - doc: use "is" rather than "has been" (Rich Trott) #21043
  • [f5bf2c8d08] - doc: move upstream information to onboarding doc (Rich Trott) #21029
  • [09aec436cb] - doc: remove vestigial onboarding section (Rich Trott) #21028
  • [fd201e0d32] - doc: add guides on writing tests involving promises (Joyee Cheung) #20988
  • [4cd44203de] - doc: remove invalid vm.Script arguments (Simen Bekkhus) #20984
  • [4012e0550a] - doc: fix typo in n-api.md (ohbarye) #21060
  • [bb8d341714] - doc: better font stack for monospace in docs (Roman Reiss) #21036
  • [1b8e8e90af] - doc: make minor improvements to fs.realpath() docs (Rich Trott) #20953
  • [c2ae93db63] - doc: add missing link for 10.3.0 changelog (Myles Borins) #21017
  • [8dc7c883a7] - doc: improve note on zlib APIs threadpool usage (Luigi Pinca) #20380
  • [ab43581f15] - doc: make constants enumeration consistent (Diego Rodríguez Baquero) #20991
  • [44ef458d9c] - fs: ensure options.flag defaults to 'r' in readFile (Unknown) #20268
  • [341b2c21f3] - http2: fix premature destroy (Anatoli Papirovski) #21051
  • [d4787cfd61] - http2: force through RST_STREAM in destroy (Anatoli Papirovski) #21016
  • [2a9912c0df] - http2: delay closing stream (Anatoli Papirovski) #20997
  • [182c73bf7f] - http2: switch to new runtime-controlled debugging system (Anna Henningsen) #20987
  • [1d22254c4d] - https: removed extra _http_server require (ErnestoSalazar) #21069
  • [1c211ec901] - inspector: code cleanup (Eugene Ostroukhov) #21070
  • [a30bf55e69] - lib: use focused ESLint disabling in util.js (Rich Trott) #21041
  • [f2c9e5af09] - lib: introduce internal/validators (Michaël Zasso) #21149
  • [46d1025add] - net: use object destructuring (starkewang) #20959
  • [afc811cc1c] - src: break out of timers loop if !can\_call\_into\_js() (Anna Henningsen) #20884
  • [8862f0a613] - src: store pointer to Environment on DestroyParam (Anatoli Papirovski) #21099
  • [66f4c7bdec] - src: fix typo string_search.h comment (Masashi Hirano) #21115
  • [f79096a3f2] - src: do not cache NumberOfHeapSpaces() globally (Anna Henningsen) #20971
  • [7c0c61bde1] - (SEMVER-MINOR) src: update postmortem constant name (cjihrig) #19989
  • [2d3137c5a9] - (SEMVER-MINOR) src: fix GetCpuProfiler() deprecation warning (Michaël Zasso) #19989
  • [af62a16ff6] - (SEMVER-MINOR) Revert "src: fix GetCpuProfiler() deprecation warning" (Michaël Zasso) #19989
  • [af06581b84] - src: restore stdio on program exit (Ben Noordhuis) #20592
  • [45eeea4330] - src: implement debug output utilities (Anna Henningsen) #20987
  • [ebbd036d0b] - src: remove unused private data member (Ben Noordhuis) #20974
  • [d4f507b23b] - src: remove unused req_wrap-inl.h (Daniel Bevenius) #20996
  • [44fe78b09a] - stream: inline needMoreData function (Miklos Suveges) #21009
  • [d1e81b0f17] - stream: ensure Stream.pipeline re-throws errors without callback (Blaine Bublitz) #20437
  • [8161287b40] - test: move benchmark-dgram to sequential (Anatoli Papirovski) #21144
  • [9d41ab466b] - test: refactor child-process-fork-net (Rich Trott) #21095
  • [820236fd0d] - test: mark test-trace-events-fs-sync as flaky (Matheus Marchini) #21039
  • [2d36150852] - test: string-decorater.lastChar (Masashi Hirano) #21084
  • [1733ef9dec] - test: make handling of noWarnCode stricter (Tobias Nießen) #21075
  • [1e607d0910] - test: add source for test.wasm (Daniel Bevenius) #21082
  • [28f2dcb22a] - test: update test-dns error message (Rich Trott) #21116
  • [c60810a853] - test: increase slop limit in memory leak test (Ben Noordhuis) #21080
  • [fda8654161] - test: log before and after RSS in memory leak test (Ben Noordhuis) #21080
  • [8e3e18ef7d] - test: unmark test-zlib.zlib-binding.deflate flaky (Anatoli Papirovski) #21109
  • [bd0d19dae7] - test: minor adjustments to test-http2-respond-file (Anna Henningsen) #21098
  • [c4fc1ff295] - test: fix flaky async-hooks/test-zlib.zlib-binding.deflate (Anna Henningsen) #21077
  • [c8ee379d85] - test: run crypto benchmark only once in tests (Rich Trott) #21032
  • [a3fdd2e4c5] - test: add option to test-benchmark-timers (Rich Trott) #21032
  • [60abd08c7f] - test: remove unused empty fixture (Rich Trott) #21044
  • [f7886ab8ad] - test: avoid empty fixture in module test (Rich Trott) #21044
  • [c74c83a4c1] - test: avoid empty fixture in fs test (Rich Trott) #21044
  • [d84aa51dc7] - test: removed message from strictEqual (Lucas Liepert) #20983
  • [e4224fd793] - test: improve path tests (Shivang) #20967
  • [df97791447] - (SEMVER-MINOR) test: update postmortem metadata test (cjihrig) #19989
  • [aa08f6464c] - (SEMVER-MINOR) test: add read_only_space heap space (cjihrig) #19989
  • [ea81d42ddc] - test: show actual error in next-tick-when-exiting (Shailesh Shekhawat) #20956
  • [7e1f61070e] - test: fix flaky test-domain-timers (Anatoli Papirovski) #21019
  • [2bbd99c7b2] - test: check TTY mode reset on exit (Anna Henningsen) #21027
  • [adbbf0d625] - test: mark test-fs-readfile-tostring-fail as flaky (Matheus Marchini) #21013
  • [ff5f20fc7b] - test: add test for fs.promises.lchmod (Masashi Hirano) #20584
  • [04af69750c] - test: mark test-child-process-fork-net as flaky (Matheus Marchini) #21018
  • [edf42985d7] - test: fix worker send error (Gireesh Punathil) #20973
  • [ba71fe8bd3] - timers: check can_call_into_js in Immediates (Anatoli Papirovski) #21057
  • [440e899d94] - tools: ensure doc-only doesn't update package-lock (Myles Borins) #21015
  • [b5b7459e5c] - trace_events: add version metadata (James M Snell) #20852
  • [4c48b69e90] - (SEMVER-MINOR) util: add type check function for BigIntObject (Michaël Zasso) #19989
  • [b2808ed929] - util: fix inspection of module namespaces (Gus Caplan) #20962
  • [ec058193a8] - v8: backport 9fb02b526f1cd3b859a530a01adb08bc0d089f4f (Gus Caplan) #20575
  • [48aa4c32d0] - zlib: removed extra util require (ErnestoSalazar) #21069

gireeshpunathil and others added 30 commits May 31, 2018 11:34
In test-child-process-fork-closed-channel-segfault.js, race condition
is observed between the server getting closed and the worker sending
a message. Accommodate the potential errors.

Earlier, the same race was observed between the client and server
and was addressed through ignoring the relevant errors through error
handler. The same mechanism is re-used for worker too.

The only difference is that the filter is applied at the callback
instead of at the worker's error listener.

Refs: #3635 (comment)
Fixes: #20836
PR-URL: #20973

Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Add missing prefix `crypto.constants.` to `RSA_PKCS1_PADDING`
in `crypto.privateEncrypt()`, `crypto.privateDecrypt()`,
`crypto.publicEncrypt()`, and `crypto.publicDecrypt()`.

PR-URL: #20991
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This commit removes the inclusion of req_wrap-inl.h from
udp_wrap.h, and tty_wrap.cc as they are not used.

PR-URL: #20996
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Raise awareness against the catastrophic memory fragmentation that can
be created while using the asynchronous zlib APIs.

PR-URL: #20380
Refs: #8871
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
PR-URL: #21017
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
PR-URL: #20974
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
`flaky-test-child-process-fork-net` has been failing constantly for the
past few days, and all solutions suggestes so far were didn't work.
Marking it as faky while the issue is not fixed.

Ref: #21012
Ref: #20973
Ref: #20973

PR-URL: #21018
Refs: #21012
Refs: #20973
Refs: #20973
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
When passing {} or { encoding: 'utf8' } as options to readFile, the
flag is not defaulted to 'r' unlike normal fs. This fix makes
fs.promises.readFile() act consistent with fs.readFile().

It also fixes another issue with fs.promises.readfile() where it
returned a Buffer instead of an empty string when encoding is provided.

PR-URL: #20268
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
To increase test coverage for fs.promises by adding a test for
lchmod.

PR-URL: #20584
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
test-fs-readfile-tostring-fail is failing frequently on OSX machines.
There's a PR to fix this issue in libuv, but while the fix don't land on
Node.js this test should be marked as flaky.

Ref: #16601
Ref: libuv/libuv#1742

PR-URL: #21013
Refs: #16601
Refs: libuv/libuv#1742
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #20962
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Make canonical vs. unique text more precise and eliminate quotation
marks. Remove repeated text from fs.realpathSync(), linking to
fs.realpath() instead.

PR-URL: #20953
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Implement utilities for easier debugging of Node.js core code,
inspired by the HTTP/2 debugging code. Debugging is, however,
implemented at runtime rather than at compile time, controlled
through a new `NODE_DEBUG_NATIVE=categories` environment variable.

The runtime overhead in the debugging-disabled case amounts to
1 well-cachable one-byte read per debug call.

PR-URL: #20987
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Remove `--debug-http2` as a compile-time feature and
make all debug statements available using `NODE_DEBUG_NATIVE=http2`
at runtime.

This probably makes the debugging-enabled case a bit slower due to
additional string concatenations, but switching to a runtime-checking
system makes debugging more flexible and can be applied more easily
to other parts of the source code as well.

PR-URL: #20987
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Record the state of the stdio file descriptors on start-up and restore
them to that state on exit.  This should prevent issues where node.js
sometimes leaves stdio in raw or non-blocking mode.

Co-authored-by: Krzysztof Taborski <taborskikrzysztof@gmail.com>
PR-URL: #20592
Fixes: #14752
Fixes: #21020
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes an issue where Stream.pipeline wouldn't re-throw errors
on a stream if no callback was specified, thus swallowing
said errors.

Fixes: #20303

PR-URL: #20437
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
There appear to be rendering issues with inconsistent glyph width when
using the Monaco font on non-macOS machines. This change updates the
native CSS font stack to use the same font stack as Boostrap does, minus
the Monaco font.

PR-URL: #21036
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yazhong Liu <yorkiefixer@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Use `TRACE_EVENT_METADATA1` to include just the node.js version for
now. Later this can be expanded to include more version and platform
details.

PR-URL: #20852
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
just replaced `than` with `that`.

- wrong: the N-API functions than can be used to change
- correct: the N-API functions that can be used to change

Fixes: #21049

PR-URL: #21060
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Before PR 20592, closing all handles associated with the main
event loop would also mean that `uv_tty_reset_mode()`
can’t function properly because the corresponding FDs have
already been closed.

Add regression tests for this condition.

Refs: #21020
Refs: #20592

PR-URL: #21027
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
It's possible for this test to be extremely infrequently flaky if
1ms or more elapses between setting the two timeouts. In that case,
the second timer will not fire and the test will fail.

PR-URL: #21019
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Delay automatically closing the stream with setImmediate in order
to allow any pushStreams to be sent first.

PR-URL: #20997
Fixes: #20992
Reviewed-By: James M Snell <jasnell@gmail.com>
If still needed, force through RST_STREAM in Http2Stream#destroy
calls, so that nghttp2 can wrap up properly and doesn't continue
trying to read & write data to the stream.

PR-URL: #21016
Fixes: #21008
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #20959
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
On process exit if some assertion error occurs value of
`process._exiting` was hidden, this fix will show the actual
error message with value.

PR-URL: #20956
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #19989
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #19989
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Synchronize source files list with upstream's BUILD.gn.

PR-URL: #19989
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Original commit message:

    [api] introduce v8::Value::IsModuleNamespaceObject

    This allows an embedder to check if a Value is a module namespace object.

    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Change-Id: Idffceff451dd5f5c6a53d4cb3ce02c1c2c5b653c
    Reviewed-on: https://chromium-review.googlesource.com/1011762
    Reviewed-by: Georg Neis <neis@chromium.org>
    Commit-Queue: Georg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52597}

Refs: v8/v8@39d546a

PR-URL: #20016
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: v8/v8@9fb02b5

Original commit message:

    Allow function callbacks to have Proxy as receiver.

    R=verwaest@chromium.org

    Bug: v8:5773
    Change-Id: Ifd29a1116ee8c86b8d8d24485bbfd19e260ab66b
    Reviewed-on: chromium-review.googlesource.com/1046088
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#53015}

PR-URL: #20575
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos
Copy link
Member

targos commented Jun 6, 2018

stream: ensure Stream.pipeline re-throws errors without callback (Blaine Bublitz) #20437

Maybe this should be in notable changes?

addaleax and others added 3 commits June 6, 2018 14:28
Otherwise, this turns into an infinite loop when the flag
is set, because it makes `MakeCallback()` return immediately.

Backport-PR-URL: #21168
PR-URL: #20884
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Currently `make doc-only` is updating the package-lock.json
which is breaking our release build.

This adds the flags `--no-package-lock` when
running `npm install` to ensure the package-lock.json is not
changed unintentionally by running make

PR-URL: #21015
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Notable Changes:

* **deps**:
 - update V8 to 6.7.288.43 (Michaël Zasso)
   #19989
* **stream**:
  - ensure Stream.pipeline re-throws errors without callback (Blaine Bublitz)
    #20437

PR-URL: #21167
@MylesBorins
Copy link
Contributor Author

Updated changelog and backported a few more things

CI: https://ci.nodejs.org/job/node-test-pull-request/15284/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1451/

@mcollina
Copy link
Member

mcollina commented Jun 6, 2018

@targos yes, updated the PR.

@MylesBorins
Copy link
Contributor Author

MylesBorins commented Jun 6, 2018

@nodejs/platform-aix looks like we are consistently getting the AIX failure

sequential/test-fs-readfile-tostring-fail

https://ci.nodejs.org/job/node-test-commit-aix/15560/testReport/

timing out

edit:
one more run of aix CI... this test seems to be flip flopping as passing / failing https://ci.nodejs.org/job/node-test-commit-aix/15562/

@gabrielschulhof
Copy link
Contributor

@MylesBorins is it too late to squeeze #21129 (a regression fix) into this release?

@MylesBorins
Copy link
Contributor Author

@gabrielf if we were to do that we are going to likely have to push the release by 24 hours, which I would prefer not to do. I'm about to wrap up for the day and don't have time to re run CI + CITGM.

If the AIX CI fails again I may just push the release anyways, will keep you up to date

@MylesBorins
Copy link
Contributor Author

rerun of AIX looks good moving forward with promotion

@MylesBorins MylesBorins merged commit 1e88953 into v10.x Jun 6, 2018
MylesBorins added a commit that referenced this pull request Jun 6, 2018
MylesBorins added a commit that referenced this pull request Jun 6, 2018
Notable Changes:

* **deps**:
 - update V8 to 6.7.288.43 (Michaël Zasso)
   #19989
* **stream**:
  - ensure Stream.pipeline re-throws errors without callback (Blaine Bublitz)
    #20437

PR-URL: #21167
@addaleax
Copy link
Member

addaleax commented Jun 6, 2018

Fwiw, it was my understanding that V8 major bumps in existing release lines would come with at least one RC or so? I’m not having any specific concern here, but I’d appreciate it if we could clarify whether there is any rule around that?

@addaleax addaleax deleted the v10.4.0-proposal branch June 6, 2018 14:34
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Jun 6, 2018 via email

Matoran added a commit to Matoran/ccxt that referenced this pull request Jul 1, 2021
ccxt is now using BigInt ccxt#9439
which have been included to nodejs 10.4.0
nodejs/node#21167 check 4c48b69e90
nodejs/node@4c48b69e90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.