doc: remove POST_STATUS_TO_PR from onboarding.md #21042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POST_STATUS_TO_PR is checked/enabled by default so there is no longer a need to mention that it should be checked in onboarding.md. There is almost never a situation when it should be unchecked.
refack
approved these changes
May 30, 2018
maclover7
approved these changes
May 30, 2018
vsemozhetbyt
approved these changes
May 30, 2018
vsemozhetbyt
added
meta
trivikr
approved these changes
May 31, 2018
tniessen
approved these changes
May 31, 2018
jasnell
approved these changes
May 31, 2018
lpinca
approved these changes
May 31, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 1, 2018
POST_STATUS_TO_PR is checked/enabled by default so there is no longer a need to mention that it should be checked in onboarding.md. There is almost never a situation when it should be unchecked. PR-URL: nodejs#21042 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in cbd82a9 |
MylesBorins
pushed a commit
that referenced
this pull request
Jun 6, 2018
POST_STATUS_TO_PR is checked/enabled by default so there is no longer a need to mention that it should be checked in onboarding.md. There is almost never a situation when it should be unchecked. PR-URL: #21042 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POST_STATUS_TO_PR is checked/enabled by default so there is no longer a
need to mention that it should be checked in onboarding.md. There is
almost never a situation when it should be unchecked.
Checklist