test: show actual assertion error message with value #20956
Conversation
| const assert = require('assert'); | ||
|
|
||
| process.on('exit', () => { | ||
| assert.strictEqual(process._exiting, true, 'process._exiting was not set!'); | ||
| // process._exiting was not set! |
There was a problem hiding this comment.
Nit: I think the comment is not needed.
There was a problem hiding this comment.
Sure, Actually this is my first PR, and not sure why windows test failed
I am a mac user, is there anything I can do to fix it?
There was a problem hiding this comment.
The failure is unrelated, don't worry about that.
|
@thatshailesh would you be so kind and rebase? Seems like you accidentally added the latest commit and that has to be backed out again. |
|
@BridgeAR Sorry, I just did rebase, now only my commits are showing |
| process.nextTick(() => { | ||
| assert.fail('process is exiting, should not be called.'); | ||
| }); | ||
| process.nextTick(common.mustNotCall()); |
There was a problem hiding this comment.
How about this?:
process.nextTick(common.mustNotCall('process is exiting, should not be called'));
|
Looks like you may have accidentally included a package-lock.json update too? You can remove that change, I would think, or whoever is landing this can remove it. (The removed change will probably be the same change proposed in #20970.) |
on process exit if some assertion error occurs value of `process._exiting` was hidden, this fix will show the actual error message with value
|
@Trott ok I have removed it, thanks 👍 |
BridgeAR
added
the
author ready
|
Landed in 8055bdb Congrats on your first contribution @thatshailesh! |
On process exit if some assertion error occurs value of `process._exiting` was hidden, this fix will show the actual error message with value. PR-URL: #20956 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
@apapirovski @Trott Thanks for the help 👍 |
On process exit if some assertion error occurs value of `process._exiting` was hidden, this fix will show the actual error message with value. PR-URL: #20956 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
on process exit if some assertion error occurs value of
process._exitingwas hidden, this fix will show the actual error message with value
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes