Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v6.x backport] win, build: fix intl-none and without-intl options #19485

Closed
wants to merge 2 commits into from
Closed

[v6.x backport] win, build: fix intl-none and without-intl options #19485

wants to merge 2 commits into from

Commits on Mar 20, 2018

  1. win, build: fix without-intl option 

    Fixes --with-intl option passed to configure script when without-intl
is used

PR-URL: nodejs#17614
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    @bzoz @poiru
    bzoz authored and poiru committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    caa4f85 View commit details
    Browse the repository at this point in the history

  2. win, build: fix intl-none option 

    Like nodejs#17614, but for the `intl-none` option.

Refs: nodejs#17614
PR-URL: nodejs#18292
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
    @poiru
    poiru committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    0bd6b1d View commit details
    Browse the repository at this point in the history