Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win, build: fix without-intl option #17614

Closed
wants to merge 1 commit into from
Closed

win, build: fix without-intl option #17614

wants to merge 1 commit into from

Conversation

bzoz
Copy link
Contributor

@bzoz bzoz commented Dec 11, 2017

Fixes --with-intl option passed to configure script when without-intl is used.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

@bzoz
win, build: fix without-intl option
1182786 
Fixes --with-intl option passed to configure script when without-intl
is used
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Dec 11, 2017
@bzoz
Copy link
Contributor Author

bzoz commented Dec 11, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/12038/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 12, 2017
@BridgeAR
Copy link
Member

Shall we fast track this?

gireeshpunathil pushed a commit that referenced this pull request Dec 15, 2017
@bzoz @gireeshpunathil
win, build: fix without-intl option
b021169 
Fixes --with-intl option passed to configure script when without-intl
is used

PR-URL: #17614
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gireeshpunathil
Copy link
Member

Landed as b021169

MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@bzoz @MylesBorins
win, build: fix without-intl option
7bf4102 
Fixes --with-intl option passed to configure script when without-intl
is used

PR-URL: #17614
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
@TimothyGu TimothyGu removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 13, 2018
@poiru poiru mentioned this pull request Jan 22, 2018
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@bzoz @MylesBorins
win, build: fix without-intl option
4899eea 
Fixes --with-intl option passed to configure script when without-intl
is used

PR-URL: #17614
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@bzoz @gibfahn
win, build: fix without-intl option
6df169c 
Fixes --with-intl option passed to configure script when without-intl
is used

PR-URL: #17614
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax pushed a commit that referenced this pull request Feb 4, 2018
@poiru @addaleax
win, build: fix intl-none option
c9ce5c3 
Like #17614, but for the `intl-none` option.

Refs: #17614
PR-URL: #18292
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@poiru @MylesBorins
win, build: fix intl-none option
c573804 
Like #17614, but for the `intl-none` option.

Refs: #17614
PR-URL: #18292
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@poiru @MylesBorins
win, build: fix intl-none option
9b86080 
Like #17614, but for the `intl-none` option.

Refs: #17614
PR-URL: #18292
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@poiru @MylesBorins
win, build: fix intl-none option
c34e2f4 
Like #17614, but for the `intl-none` option.

Refs: #17614
PR-URL: #18292
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@MylesBorins
Copy link
Contributor

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@poiru @MylesBorins
win, build: fix intl-none option
ea06886 
Like #17614, but for the `intl-none` option.

Refs: #17614
PR-URL: #18292
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
poiru pushed a commit to poiru/node that referenced this pull request Mar 20, 2018
@bzoz @poiru
win, build: fix without-intl option
caa4f85 
Fixes --with-intl option passed to configure script when without-intl
is used

PR-URL: nodejs#17614
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
poiru added a commit to poiru/node that referenced this pull request Mar 20, 2018
@poiru
win, build: fix intl-none option
0bd6b1d 
Like nodejs#17614, but for the `intl-none` option.

Refs: nodejs#17614
PR-URL: nodejs#18292
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@poiru poiru mentioned this pull request Mar 20, 2018
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
@bzoz @MylesBorins
win, build: fix without-intl option
ca4b4a9 
Fixes --with-intl option passed to configure script when without-intl
is used

Backport-PR-URL: #19485
PR-URL: #17614
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
@poiru @MylesBorins
win, build: fix intl-none option
331b4fd 
Like #17614, but for the `intl-none` option.

Backport-PR-URL: #19485
Refs: #17614
PR-URL: #18292
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@bzoz @MylesBorins
win, build: fix without-intl option
a47fda4 
Fixes --with-intl option passed to configure script when without-intl
is used

Backport-PR-URL: #19485
PR-URL: #17614
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@poiru @MylesBorins
win, build: fix intl-none option
d4d4cec 
Like #17614, but for the `intl-none` option.

Backport-PR-URL: #19485
Refs: #17614
PR-URL: #18292
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@poiru @MylesBorins
win, build: fix intl-none option
21441e8 
Like #17614, but for the `intl-none` option.

Refs: #17614
PR-URL: #18292
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@bzoz @MylesBorins
win, build: fix without-intl option
6ff763b 
Fixes --with-intl option passed to configure script when without-intl
is used

Backport-PR-URL: #19485
PR-URL: #17614
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@poiru @MylesBorins
win, build: fix intl-none option
a91b1b9 
Like #17614, but for the `intl-none` option.

Backport-PR-URL: #19485
Refs: #17614
PR-URL: #18292
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@poiru @MylesBorins
win, build: fix intl-none option
c61754f 
Like #17614, but for the `intl-none` option.

Refs: #17614
PR-URL: #18292
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@MylesBorins MylesBorins mentioned this pull request Apr 13, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@poiru @MayaLekova
win, build: fix intl-none option
12d554c 
Like nodejs#17614, but for the `intl-none` option.

Refs: nodejs#17614
PR-URL: nodejs#18292
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bzoz @BridgeAR @gireeshpunathil @MylesBorins @jasnell @addaleax @richardlau @TimothyGu @nodejs-github-bot