Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6.x backport] win, build: fix intl-none and without-intl options #19485

Closed
wants to merge 2 commits into from

Conversation

poiru
Copy link
Contributor

@poiru poiru commented Mar 20, 2018

This backports #17614 and #18292.

Checklist

bzoz and others added 2 commits March 20, 2018 19:01
Fixes --with-intl option passed to configure script when without-intl
is used

PR-URL: nodejs#17614
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Like nodejs#17614, but for the `intl-none` option.

Refs: nodejs#17614
PR-URL: nodejs#18292
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v6.x windows Issues and PRs related to the Windows platform. labels Mar 20, 2018
@MylesBorins
Copy link
Contributor

MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
Fixes --with-intl option passed to configure script when without-intl
is used

Backport-PR-URL: #19485
PR-URL: #17614
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
Like #17614, but for the `intl-none` option.

Backport-PR-URL: #19485
Refs: #17614
PR-URL: #18292
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@MylesBorins
Copy link
Contributor

landed in fe477e4...331b4fd

MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
Fixes --with-intl option passed to configure script when without-intl
is used

Backport-PR-URL: #19485
PR-URL: #17614
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
Like #17614, but for the `intl-none` option.

Backport-PR-URL: #19485
Refs: #17614
PR-URL: #18292
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
Fixes --with-intl option passed to configure script when without-intl
is used

Backport-PR-URL: #19485
PR-URL: #17614
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
Like #17614, but for the `intl-none` option.

Backport-PR-URL: #19485
Refs: #17614
PR-URL: #18292
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants