-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
broken behavior of server.close and keepAlive in node v18.19.0 and above. Works as expected until v18.18.2 #52330
Comments
Appreciate any help/input here. Thank you CC: @bnoordhuis is it duplicate of #51677 Can someone explain expected behavior? This is my expectation: It appears that keep-alive timeout doesn't has much value after server.close? What's the new behavior, if ongoing connection - not idle one (while server.close occurs) takes more time than keepAlive. I assume it won't exist untill that complete unless forced close. right? |
Correcting the nodejs#50194 backporting mistake. server.closeIdleConnections shouldn't be called while server.close in node v18. This behavior is for node v19 and above. fixes: nodejs#52330, nodejs#51677,
Correcting the nodejs#50194 backporting mistake. closeIdleConnections shouldn't be called while server.close in node v18. This behavior is for node v19 and above. fixes: nodejs#52330, nodejs#51677,
….\n Correcting the nodejs#50194 backporting mistake.\n closeIdleConnections shouldnot be called while server.close in node v18.\n This behavior is for node v19 and above.\n fixes: nodejs#52330, nodejs#51677
Correcting the nodejs#50194 backporting mistake. closeIdleConnections shouldnot be called while server.close in node v18. This behavior is for node v19 and above. fixes: nodejs#52330, nodejs#51677
Correcting the nodejs#50194 backporting mistake. closeIdleConnections shouldnot be called while server.close in node v18. This behavior is for node v19 and above. fixes: nodejs#52330, nodejs#51677
Correcting the nodejs#50194 backporting mistake. closeIdleConnections shouldnot be called while server.close in node v18. This behavior is for node v19 and above. fixes: nodejs#52330, nodejs#51677
Version
18.19.0
Platform
Darwin XXXXXXX 23.4.0 Darwin Kernel Version 23.4.0: Wed Feb 21 21:44:43 PST 2024; root:xnu-10063.101.15~2/RELEASE_ARM64_T6000 arm64
Subsystem
No response
What steps will reproduce the bug?
Mentioned in this discussion:
https://github.com/orgs/nodejs/discussions/52224#discussioncomment-8987176
After digging more, I found that this behavior started in node v18.19.0 .
It worked fine until v18.18.2
How often does it reproduce? Is there a required condition?
Always
What is the expected behavior? Why is that the expected behavior?
There shouldn't be a broken behavior in minor release
What do you see instead?
failure
Additional information
No response
The text was updated successfully, but these errors were encountered: