-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v18.x] http: remove closeIdleConnections function while calling server close. #52336
Conversation
Review requested:
|
Correcting the nodejs#50194 backporting mistake. closeIdleConnections shouldnot be called while server.close in node v18. This behavior is for node v19 and above. fixes: nodejs#52330, nodejs#51677
the timeout tests should not be deleted, as they check the interval change which is still kept. |
Correct. I doubted that too. I misunderstood the previous message regarding deleting test. @Linkgoron |
@Linkgoron should i be raising the PR against v18.x or v18.x-staging branch? CC: @richardlau |
v18.x-staging. |
Done |
can we go ahead with review and merge? |
can we target this for v18.20.3 release? |
Will there be separate PR for v19/20/21 ? or does this propagate to newer versions? |
No. This new behavior is expected in v19 and above. https://nodejs.org/docs/latest-v19.x/api/http.html#serverclosecallback This PR is only for v18 where this is not expected and was a backporting mistake. https://nodejs.org/docs/latest-v18.x/api/http.html#serverclosecallback |
@richardlau can we get this merge and land on v18? |
Landed in 6689a98. |
Correcting the #50194 backporting mistake.
closeIdleConnections shouldnot be called while server.close in node v18. This behavior is for node v19 and above.
fixes: #52330, #51677