Skip to content

Commit

Permalink
https: remove closeIdleConnections function while calling server close
Browse files Browse the repository at this point in the history
Correcting the nodejs#50194 backporting mistake. server.closeIdleConnections shouldn't be called while server.close in node v18. This behavior is for node v19 and above.

fixes: nodejs#52330, nodejs#51677,
  • Loading branch information
kumarrishav authored Apr 2, 2024
1 parent 8c8961d commit 37b3e06
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/_http_server.js
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,6 @@ function setupConnectionsTracking() {
}

function httpServerPreClose(server) {
server.closeIdleConnections();
clearInterval(server[kConnectionsCheckingInterval]);
}

Expand Down

0 comments on commit 37b3e06

Please sign in to comment.