Improve password protection UX and UI. #607
Conversation
js/views/callinfoview.js
Outdated
| @@ -284,6 +301,9 @@ | |||
| }.bind(this) | |||
| }); | |||
|
|
|||
| this.ui.passwordOption.hide(); | |||
| this.ui.passwordButton.show(); | |||
There was a problem hiding this comment.
It would be better to move this into the success function.
Also, if there is an error in the ajax call it should be handled by letting the user know somehow (but without hiding the input field).
👍
👍 |
We should do that via opacity as it’s much more clear. When no password is set, the icon should be
If we do that then we should have that on any call though, also group calls. So we should have a separate element to overlay the password icon there. |
Password protection is only available in public calls. |
|
Please also send a PR against master 🙊 (or better rebase this one) |
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Ivansss
force-pushed
the
improve-password-protection-ui
branch
from
123b442
to
a8de18e
Compare
|
Rebased and changed base branch. |
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
…uccess. Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
|
@jancborchardt The password input field is shown in a popover menu now. |
Ivansss
force-pushed
the
improve-password-protection-ui
branch
from
0aac052
to
4c5af57
Compare
Password input caught to much attention in the right side bar.
It will be hidden by default and a password button will replace it.
@jancborchardt It would be nice to have an 'opened lock' icon so we can show it when the room has no password set.
Also, we could have a new combined icon (public + password) for the left side bar, so a user could see directly which public calls are password protected without being in that room.
Something like this:
