Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable 13] Improve password protection UX and UI #650

Merged
merged 4 commits into from
Feb 13, 2018
Merged

[stable 13] Improve password protection UX and UI #650

merged 4 commits into from
Feb 13, 2018

Conversation

Ivansss
Copy link
Member

@Ivansss Ivansss commented Feb 12, 2018

Backport of #607

@Ivansss
Add a button to show/hide password input.
6477628 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Set opened lock icon when no password is set.
05349ae 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Notify on error while setting password and hide input field only on s…
001cd1a 
…uccess.

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Remove debug logs.
43cdb6f 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
danxuliu
danxuliu approved these changes Feb 13, 2018
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works; code looks good 👍

@danxuliu danxuliu added this to the 3.1 (Nextcloud 13.0.2/3) milestone Feb 13, 2018
@Ivansss Ivansss merged commit cf64d2e into stable13 Feb 13, 2018
@Ivansss Ivansss deleted the stable13-607-improve-password-protection-ui branch February 13, 2018 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
3. to review design enhancement
Projects
None yet
Milestone
3.1 (Nextcloud 13.0.0/1)
Development

Successfully merging this pull request may close these issues.
2 participants
@Ivansss @danxuliu