-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More design work & clean up to reduce possible height of room details #562
Conversation
Added some screenshots and put some proper layout in the room info. :) I really like it, what do you think @nickvergessen @Ivansss @danxuliu? |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@nickvergessen will look into fixing that, ok. @Ivansss as said above: if you think it’s necessary or can do it, we could also move the Password input into a 3-dot menu popover (icon right next to copy link). But this is already much better. :) |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
8b997c5
to
1ebce24
Compare
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
I know this change was done to reduce the height of the header. If the call is shared the set/change password will be always visible, so the height of the header will be the same in both cases. But this is just my opinion 😊 what do you guys think? |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@nickvergessen fixed everything you mentioned. :)
@Ivansss that is precisely why I mentioned twice now ;) that the password should be in a popover, like we had in the 3-dot-menu in the sidebar. It really should not be displayed the whole time, it’s unnecessary and distracting. |
We have apps for mobile and all others should have big enough screens to handle this? |
Well, these fixes are already better than the current state in many respects. The thing to postpone (if needed) is only the move of the password input to a popover. But even without that this is good to merge. |
But the chat is not implemented yet in the mobile apps, or is it?
Like @Ivansss I prefer the sharing options below the Join call button too :-P |
Okay, so lets keep the current for 3.0 and fix it in a good looking way for 3.1 (which is only some days away, we will release independent from server) |
Talked with @Ivansss, we will leave it for 3.0 like current, and for 3.1 do it like this here, with a »Lock« icon next to the Copy link icon, which will open a popover bubble for the password. |
(This also fixes a bug which only occurs with very long room names where the edit button is shown below the name and makes the whole layout jump btw.) |
I would give it a try. The password input field is way to eye-catching |
Conflicting and needs major changes, closing for now, please redo in little steps so we can merge them quickly. |
Add datetime picker docs
@danxuliu if you think it’s necessary or can do it, we could also move the Password input into a 3-dot menu popover (icon right next to copy link). But this is already much better. :)
-
Ref #558 (comment)