Show password input field in a popover menu. #647

Ivansss · 2018-02-12T11:32:16Z

Following #607
Also fix #563

Signed-off-by: Ivan Sein <ivan@nextcloud.com>

danxuliu · 2018-02-14T11:24:04Z

Not ready for review yet.

@jancborchardt this still needs some design love as mentioned by @Ivansss in the previous pull request.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

skjnldsv · 2018-03-22T17:22:19Z

The requirements for a proper popovermenu are documented here: https://docs.nextcloud.com/server/14/developer_manual/design/popovermenu.html :)

skjnldsv · 2018-03-23T16:28:04Z

@nickvergessen @danxuliu the small confirm button is fixed in master: nextcloud/server#8777

nickvergessen · 2018-03-26T10:31:11Z

css/style.scss

-}
-
-.newCommentRow .editable-text-label .label {
-	margin-left: 5px;


Can you bring this back, looks much better then, because name and chat input are in line

nickvergessen · 2018-03-26T10:34:08Z

js/views/callinfoview.js

 		},

 		renderWhenInactive: function() {
-			if (this.ui.passwordInput.length === 0 || !this.passwordInputIsShown || this.ui.passwordInput.val() === '') {


This is required for firefox, when you have one password saved in your browser.
Otherwise the call info will never update, because the password is always non-empty

With the auto-fill?

Yes, firefox fills it, although autocomplete off/new-password/...

You can test it:

Create a public room

Click on join

Approve media permissions

Button still says "Join" instead of "Leave"

Damn firefox!!

https://github.com/nextcloud/spreed/pull/717/files :(

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

nickvergessen · 2018-03-26T11:33:38Z

Btw is hte > needed?
I don't think it adds valuable information:

skjnldsv · 2018-03-26T12:09:13Z

@nickvergessen an icon is required in a popovermenu. I found the most basic one, sorry ! :)
Please suggest another! :p

nickvergessen · 2018-03-26T12:21:01Z

Dreaming: "an open lock which changes to a closed one, when you start typing a password" xP

Okay then be it a triangle

nickvergessen · 2018-03-26T13:10:45Z

js/views/callinfoview.js

@@ -28,6 +28,8 @@
 	OCA.SpreedMe = OCA.SpreedMe || {};
 	OCA.SpreedMe.Views = OCA.SpreedMe.Views || {};

+	var uiChannel = Backbone.Radio.channel('ui');


ESlint fails:

/drone/src/github.com/nextcloud/spreed/js/views/callinfoview.js
31:6 error 'uiChannel' is defined but never used no-unused-vars

Must be a rebase error, I don't recall adding this line! Let me remove it!

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Signed-off-by: Joas Schilling <coding@schilljs.com>

skjnldsv · 2018-03-27T12:26:12Z

js/views/callinfoview.js

@@ -186,7 +186,7 @@
 		},

 		renderWhenInactive: function() {
-			if (this.ui.passwordInput.length === 0 || (OC._currentMenu && OC._currentMenu.hasClass('password-menu')) || this.ui.passwordInput.val() === '') {
+			if (!OC._currentMenu || !OC._currentMenu.hasClass('password-menu') || this.ui.passwordInput.length === 0 || this.ui.passwordInput.val() === '') {


Nope, OC._currentMenu can be set to another menu like the apps menu or the setting one :)

Exactly, but it is okay to reload the side bar when you have another menu open, just not the password field, because it would overwrite your changes.
Note this if is the evil thing, when we don't go inside, we will just retry later.

Performance-side, why reload it on another menu click? Seems unnecessary :)

It's not on click, it's on "model changed" and that may be in the background when the room list is updated (happens on pull after a notification that there was a change...).
We jsut want to prevent rerendering while the user is typing a password.

Ah okay! :)
Then it's 👍 for me!

nickvergessen · 2018-04-19T14:13:26Z

Is this already backported? at least it doesn't work cleanly for me, although everything which was merged to master before this one is already backported....

Show password input field in a popover menu.

0aac052

Signed-off-by: Ivan Sein <ivan@nextcloud.com>

Ivansss added backport-request design enhancement labels Feb 12, 2018

Ivansss requested review from nickvergessen, jancborchardt and danxuliu February 12, 2018 11:32

nickvergessen added this to the 4.0 (Nextcloud 14) milestone Feb 12, 2018

danxuliu added the 2. developing label Feb 14, 2018

skjnldsv self-assigned this Mar 22, 2018

Fixed popover style and fit guidelines

1064a3b

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

skjnldsv added 3. to review 2. developing and removed 2. developing 3. to review labels Mar 23, 2018

Merge branch 'master' into password-popover

0812f3b

skjnldsv force-pushed the password-popover branch from 08f0d51 to 0812f3b Compare March 23, 2018 16:25

skjnldsv added 3. to review and removed 2. developing labels Mar 23, 2018

nickvergessen reviewed Mar 26, 2018

View reviewed changes

Fix css alignment

8cff63b

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

nickvergessen reviewed Mar 26, 2018

View reviewed changes

Damn you firefox autocomplete

79cc943

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

skjnldsv force-pushed the password-popover branch from 2535475 to 79cc943 Compare March 26, 2018 13:15

Invert the logic, we want to render when the menu is NOT active

b2b625f

Signed-off-by: Joas Schilling <coding@schilljs.com>

skjnldsv reviewed Mar 27, 2018

View reviewed changes

skjnldsv approved these changes Mar 27, 2018

View reviewed changes

nickvergessen merged commit 44431df into master Mar 27, 2018

nickvergessen deleted the password-popover branch March 27, 2018 13:08

This was referenced Apr 20, 2018

[stable13] Show password input field in a popover menu. #796

Merged

Add lock icon to password popover. #797

Merged

nickvergessen removed the backport-request label Apr 26, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show password input field in a popover menu. #647

Show password input field in a popover menu. #647

Ivansss commented Feb 12, 2018 •

edited by skjnldsv

Loading

danxuliu commented Feb 14, 2018

skjnldsv commented Mar 22, 2018

skjnldsv commented Mar 23, 2018

nickvergessen Mar 26, 2018

nickvergessen Mar 26, 2018

skjnldsv Mar 26, 2018

nickvergessen Mar 26, 2018

skjnldsv Mar 26, 2018

nickvergessen Mar 26, 2018

skjnldsv Mar 26, 2018

nickvergessen commented Mar 26, 2018

skjnldsv commented Mar 26, 2018 •

edited

Loading

nickvergessen commented Mar 26, 2018

nickvergessen Mar 26, 2018

skjnldsv Mar 26, 2018

skjnldsv Mar 27, 2018

nickvergessen Mar 27, 2018

skjnldsv Mar 27, 2018

nickvergessen Mar 27, 2018

skjnldsv Mar 27, 2018

nickvergessen commented Apr 19, 2018

Show password input field in a popover menu. #647

Show password input field in a popover menu. #647

Conversation

Ivansss commented Feb 12, 2018 • edited by skjnldsv Loading

danxuliu commented Feb 14, 2018

skjnldsv commented Mar 22, 2018

skjnldsv commented Mar 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickvergessen commented Mar 26, 2018

skjnldsv commented Mar 26, 2018 • edited Loading

nickvergessen commented Mar 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickvergessen commented Apr 19, 2018

Ivansss commented Feb 12, 2018 •

edited by skjnldsv

Loading

skjnldsv commented Mar 26, 2018 •

edited

Loading