-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👥 Multiple sessions 👥 #5194
👥 Multiple sessions 👥 #5194
Conversation
nickvergessen
commented
Feb 17, 2021
•
edited
Loading
edited
- 😿 For now only multiple Talk sessions in different PHP sessions will be supported. So you can be in the same conversation with mobile apps, SIP, browser, etc at the same time, but not in the same chat in 2 tabs of the same browser. The additional burden is currently too much to handle
- Transform the unique attendee key on the sessions table to a normal index
- Make sure that we always select the Talk session of the current PHP session because there could be more than 1
- In places where the session is not used, the parameter should be set to false/null, to avoid left joining an unneeded database table
- Move integration tests to API v4
- Move UI to API v4
- Remove special handling of lower API versions as the routes don't match anymore
- Add v4 capability and remove others
637d752
to
52d3c74
Compare
52d3c74
to
f7cfa87
Compare
Rebase on #5215 for compatibility |
f7cfa87
to
3d730f5
Compare
This comment has been minimized.
This comment has been minimized.
3d730f5
to
d10395b
Compare
This comment has been minimized.
This comment has been minimized.
ce4b81c
to
aab5d94
Compare
ece8735
to
d7507e5
Compare
ad81c4f
to
a23166e
Compare
Ready to review. Don't be scared about the size, it's mostly integration tests bumping the required version of the API from none (v1) or v2 or v3 to the new one-and-only v4 |
f49faf5
to
fd99482
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
69d48cd
to
12a48be
Compare
Added 3 commits and rebased. Only thing is guests see "Conversation not found" after their previous session gets kicked because of duplication, but lets fix that later. |
HPB tests
|
I've tested with HPB and all seemed to work fine. There's only a minor issue with raise hand because we don't aggregate HPB style session id in the participant list, but perhaps we can fix this separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
some integration tests are failing still: https://drone.nextcloud.com/nextcloud/spreed/1816/4/3
|
Ah yeah... that is what the fixme was about 😅 |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Also, I still have some features in my mind like "ask to unmute" or "mute from sidebar". Now since we only show a participant once during a call there the UX for such would be more tricky as we'd need to either ask the user which session they want to mute (maybe only one is unmuted by mistake) or do it for all of them. Also not sure if it's a good idea to temporarily show one participant as multiple entries in the participant list during a call. Or group them somehow with an expandable arrow. Feels like it's going too far. (increased code complexity and UX complexity for not that much benefit) |
Yeah, let's discuss this separatly. For now muting works on the call view and its okay for now. |
|
🎉 |