Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Raised hand" state not working properly in the sidebar with multiple sessions #5349

Closed
nickvergessen opened this issue Mar 9, 2021 · 6 comments · Fixed by #5482
Closed

Comments

@nickvergessen
Copy link
Member

Steps to reproduce

  1. Join a conversation with 2 sessions
  2. In the session with the lower id raise hand

Expected behaviour

Sidebar shows you raise your hand

Actual behaviour

Sidebar doesn't show you raise your hand

@PVince81
Copy link
Member

When I tested it worked fine with internal signaling, but not with the HPB.
It was likely related to the way session ids are mapped.

@nickvergessen
Copy link
Member Author

yeah it is

@PVince81
Copy link
Member

I did some quick debugging and it looks like it's going to be tricky.
The results of the participant list only contain one session id (likely the one from the aggregated "max" participant result).

Maybe we should adjust the participant API and make 'sessionId` an array ? Or for compatibility, add a new separate array that contains a list of known session ids for that participant.

@nickvergessen
Copy link
Member Author

there is no compatibility needed atm as v4 is brand new

@PVince81 PVince81 self-assigned this Apr 14, 2021
@PVince81
Copy link
Member

for now I'll go with an extra property as I'm a bit afraid of all the code paths to touch that could potentially break in our frontend.
most code paths only need to know if the session is "0" or not

@PVince81
Copy link
Member

PR here: #5482

I was able to remove the "sessionId" attribute still as the affected frontend code was minimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants