Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base queries on sessions where it makes sense #5258

Merged
merged 3 commits into from
Feb 24, 2021
Merged

Base queries on sessions where it makes sense #5258

merged 3 commits into from
Feb 24, 2021

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 24, 2021 •
edited
Loading

Split off from #5194

@nickvergessen
Make the method loop over the sessions instead of the attendees
9cc02f5 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Pick all sessions instead of attendees when returning participants on…
a347cf2 
… signaling

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
First check for session because we don't do something otherwise anyway
adc5996 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review feature: signaling 📶 Internal and external signaling backends technical debt labels Feb 24, 2021
@nickvergessen nickvergessen added this to the 💖 Next Major (22) milestone Feb 24, 2021
PVince81
PVince81 approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I could understand, this seems to make sense 👍

@nickvergessen nickvergessen merged commit 17afa97 into master Feb 24, 2021
@nickvergessen nickvergessen deleted the techdebt/noid/base-queries-on-sessions-where-it-makes-sense branch February 24, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees
No one assigned
Labels
4. to release feature: signaling 📶 Internal and external signaling backends technical debt
Projects
None yet
Milestone
v12.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @PVince81