Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👥 Multiple sessions 👥 #5194

Merged
merged 41 commits into from
Mar 9, 2021
Merged

👥 Multiple sessions 👥 #5194

merged 41 commits into from
Mar 9, 2021

Commits on Mar 8, 2021

  1. Replace the former unique attendee key with a normal index 

    This allows an attendee to have multiple sessions in the same conversation.

Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    6d9c838 View commit details
    Browse the repository at this point in the history

  2. Prepare selecting the correct session in case there are multiple 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    4031c18 View commit details
    Browse the repository at this point in the history

  3. Don't load session on getRoomsForUser when not needed 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    1caca56 View commit details
    Browse the repository at this point in the history

  4. Don't load the session by default on getParticipantsForRoom 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    0e20ca5 View commit details
    Browse the repository at this point in the history

  5. Group multiple sessions of the same attendee 

    Combine the session values:
* All inCall bit flags
* Newest lastPing
* Any sessionId (for online checking)

Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    c97f55e View commit details
    Browse the repository at this point in the history

  6. Fix selecting the session when there could be multiple 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    6ad31df View commit details
    Browse the repository at this point in the history

  7. Don't clear previous sessions when joining 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    783fb00 View commit details
    Browse the repository at this point in the history

  8. Fix session selection in signaling code 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    723d47f View commit details
    Browse the repository at this point in the history

  9. Only load sessions on the room list for this PHP session 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    a545cff View commit details
    Browse the repository at this point in the history

  10. Make the UI handle the call state on it's interactions instead of the… 

    … participant data

The user could have joined the call in another window/device and shouldn't jump to the call view
for this window unless the user pressed "Join call" here as well

Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    6184127 View commit details
    Browse the repository at this point in the history

  11. Show a "Connecting …" screen until we finished joining 

    If by accident we never receive a users list, just switch to
"Waiting for others to join the call …" after some seconds.

Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    6902e57 View commit details
    Browse the repository at this point in the history

  12. Move listed rooms to API v4 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    5bff56f View commit details
    Browse the repository at this point in the history

  13. Move lobby and SIP to v4 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    79d52e6 View commit details
    Browse the repository at this point in the history

  14. Move conversation creation to v4 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    7673f4f View commit details
    Browse the repository at this point in the history

  15. Move get rooms to API v4 

    Added FIXMEs for participant parameters that should check the participant endpoint instead

Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    1b4b1c6 View commit details
    Browse the repository at this point in the history

  16. Check users on correct endpoint 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    174789f View commit details
    Browse the repository at this point in the history

  17. Move get participants to API v4 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    8eae2e8 View commit details
    Browse the repository at this point in the history

  18. Add API version to files/share integration tests 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    5ba0871 View commit details
    Browse the repository at this point in the history

  19. Make joining a room API v4 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    e331d29 View commit details
    Browse the repository at this point in the history

  20. Make leaving a room API v4 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    6c0246b View commit details
    Browse the repository at this point in the history

  21. Move removing paricipants to v4 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    3a680dc View commit details
    Browse the repository at this point in the history

  22. Move deleting and getting a room to v4 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    db7c09e View commit details
    Browse the repository at this point in the history

  23. Move room modifications to API v4 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    0aedba5 View commit details
    Browse the repository at this point in the history

  24. Move other participant handling to API v4 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    4aee4e9 View commit details
    Browse the repository at this point in the history

  25. Move other room APIs to v4 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    7eaafce View commit details
    Browse the repository at this point in the history

  26. Move call API to v4 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    3fed42b View commit details
    Browse the repository at this point in the history

  27. Chat, Settings and Guests are v1 api only atm 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    64a28fa View commit details
    Browse the repository at this point in the history

  28. Document return types as well 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    7b1a8ee View commit details
    Browse the repository at this point in the history

  29. Statuses are integers now 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    ba52825 View commit details
    Browse the repository at this point in the history

  30. We have the full room data already 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    8136513 View commit details
    Browse the repository at this point in the history

  31. Add conversation-v4 capability 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    5ed91b8 View commit details
    Browse the repository at this point in the history

  32. Move to APIv4 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    a3cf504 View commit details
    Browse the repository at this point in the history

  33. Remove old API version handlings 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    84fa567 View commit details
    Browse the repository at this point in the history

  34. Check the participants on the correct endpoint 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    5f29407 View commit details
    Browse the repository at this point in the history

  35. Fix integration tests by saving the attendee id or loading it 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    1dd9297 View commit details
    Browse the repository at this point in the history

  36. Handle all getParticipants with multi sessions 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    928e047 View commit details
    Browse the repository at this point in the history

  37. Trespassing only with session 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    baa1547 View commit details
    Browse the repository at this point in the history

  38. No duplicate session warning per se 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    1bb090a View commit details
    Browse the repository at this point in the history

  39. Leaving with a session as guest is now also not quiting anymore 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    2183ffc View commit details
    Browse the repository at this point in the history

  40. Fix HPB missing event when a session is terminated only 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    12a48be View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Fix removing yourself and promoting a stranger 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    1e9c21e View commit details
    Browse the repository at this point in the history