Update "External storages" to current file list layout #7658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the checkbox was moved to where the favourite icon was shown before the layout of the file list was modified. The first column is no longer the file name, so neither the thumbnail nor the name link were found. Due to this the thumbnail was not set to the appropriate icon, and the dummy event handler was not removed from the name link, so clicks on the name were basically ignored. Now the selectors are based on the ".filename" CSS class instead of relying on the column position. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
When the checkbox was moved to where the favourite icon was shown before the layout of the file list was modified. The checkbox is no longer a descendant of the ".filename" element, so it is no longer removed by the "External storages" file list. However, even before the checkbox was moved, explicitly removing it was not the best approach, as file list rows could still be selected using "Ctrl/Shift+click". This did not provide much value, as the selection header has no actions; it simply states the number of selected elements. The proper way to disable the selection is by setting "_allowSelection" to false in the file list instead. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
3. to review
This was referenced Jan 2, 2018
Merged
MorrisJobke
added
4. to release
MorrisJobke
deleted the
update-external-storages-to-current-file-list-layout
branch
Codecov Report
@@ Coverage Diff @@
## master #7658 +/- ##
============================================
+ Coverage 51.17% 51.23% +0.06%
- Complexity 24886 24927 +41
============================================
Files 1602 1602
Lines 94752 94889 +137
Branches 1368 1371 +3
============================================
+ Hits 48486 48616 +130
- Misses 46266 46273 +7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the checkbox was moved to where the favourite icon was shown before the layout of the file list was modified. The first column is no longer the file name, so neither the thumbnail nor the name link were found. Due to this the thumbnail was not set to the appropriate icon, and the dummy event handler was not removed from the name link, so clicks on the name were basically ignored.
The layout change also caused the checkbox to not be removed on the External storages file list; as the header has no checkbox column but the body rows do the file list looks broken. However, in this case the proper fix is to set
_allowSelection: falsein the file list object instead of explicitly removing the checkbox (it should have been done that way even before the layout change).Fixes (theoretically; please test ;-) ) #7388 and #7437
When testing this please note that marking an external storage as a favourite and other actions do not work as expected in the External storage file list (although they do in All files). That is a different issue unrelated to the layout and it will be fixed in another pull request.