Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes actions on a mounted storage #7638

Closed
wants to merge 1 commit into from
Closed

Conversation

amkad
Copy link

@amkad amkad commented Dec 28, 2017

Fixes #7437 that looks like a regress after introducing the selection column.

Unfortunately, I do not know the project well enough to create from scratch a test for statusmanager.js

Signed-off-by: Alexey Kaigorodov <amkad@mail.ru>
@rullzer
Copy link
Member

rullzer commented Dec 29, 2017

Again awesome work @amkad feel free to also join #nextcloud-dev on freenode!

@danxuliu can you have a look?

@rullzer rullzer added this to the Nextcloud 13 milestone Dec 29, 2017
@rullzer rullzer added 3. to review Waiting for reviews high labels Dec 29, 2017
@danxuliu
Copy link
Member

danxuliu commented Jan 2, 2018

@amkad Thanks for your contribution!

I had already fixed this a few days ago, but I did not create the pull request 🤦 Sorry!

I have created it now because it includes some additional fixes too (the icon and the External storages file list layout): #7658 Due to those additional fixes I hope that you do not mind if I close this one :-)

@danxuliu danxuliu closed this Jan 2, 2018
@amkad
Copy link
Author

amkad commented Jan 2, 2018

@danxuliu No worries! I'll be glad to see this change in the master.

@amkad amkad deleted the bug-7437 branch January 3, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants