Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "External storages" to current file list layout #7658

Merged
merged 2 commits into from
Jan 2, 2018
Merged

Update "External storages" to current file list layout #7658

merged 2 commits into from
Jan 2, 2018

Commits on Dec 27, 2017

  1. Fix selectors for file list elements 

    When the checkbox was moved to where the favourite icon was shown before
the layout of the file list was modified. The first column is no longer
the file name, so neither the thumbnail nor the name link were found.
Due to this the thumbnail was not set to the appropriate icon, and the
dummy event handler was not removed from the name link, so clicks on the
name were basically ignored. Now the selectors are based on the
".filename" CSS class instead of relying on the column position.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu
    danxuliu committed Dec 27, 2017
    Configuration menu
    Copy the full SHA
    78891ac View commit details
    Browse the repository at this point in the history

  2. Disable selection in "External storages" file list 

    When the checkbox was moved to where the favourite icon was shown before
the layout of the file list was modified. The checkbox is no longer a
descendant of the ".filename" element, so it is no longer removed by the
"External storages" file list.

However, even before the checkbox was moved, explicitly removing it was
not the best approach, as file list rows could still be selected using
"Ctrl/Shift+click". This did not provide much value, as the selection
header has no actions; it simply states the number of selected elements.
The proper way to disable the selection is by setting "_allowSelection"
to false in the file list instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu
    danxuliu committed Dec 27, 2017
    Configuration menu
    Copy the full SHA
    1112516 View commit details
    Browse the repository at this point in the history