[Wanda Refactor] Wanda/OBCQ Modifier Refactor #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-tuli
force-pushed
the
layer-compressor-contract
branch
from
cf70132
to
2832d52
Compare
Fix some docstrings
rahul-tuli
force-pushed
the
wanda-modifier-refactor
branch
from
24535d1
to
944455e
Compare
This was referenced Dec 18, 2023
rahul-tuli
added a commit
that referenced
this pull request
Dec 28, 2023
* Add wanda base * Initial implementation * Update Wanda Base * Refactor to use WandaLayerCompressor Update WrappedGPT * Rename WrappedGPT to WandaGPT * [Wanda Refactor] Wanda/OBCQ Modifier Refactor (#1887) * Define GPT contract * rename tmp -> batch_size * Define LayerCompressor Contract * Rename gpt_helpers to gpts Fix some docstrings * add named argument to function call * Wanda/OBCQ refactor * propagate target-ids * Address review comments from * #1885 * #1886 * Fix typo * Update test * Fix regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanda can be thought of as a simpler/more-general case of OBCQ; this PR leverages that to reduce code duplicacy