-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wanda Refactor] Define LayerCompressor
Contract
#1886
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-tuli
changed the title
Define LayerCompressor Contract
[Wanda Refactor] Define Dec 7, 2023
LayerCompressor
Contract
Satrat
approved these changes
Dec 7, 2023
rahul-tuli
force-pushed
the
layer-compressor-contract
branch
from
December 11, 2023 15:15
cf70132
to
2832d52
Compare
bfineran
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending name update
rahul-tuli
force-pushed
the
define-gpt-contract
branch
from
December 12, 2023 16:33
86bbaed
to
c6f9ab0
Compare
rahul-tuli
added a commit
that referenced
this pull request
Dec 18, 2023
Closing cause requested changes are now a part of #1887 |
rahul-tuli
added a commit
that referenced
this pull request
Dec 28, 2023
* Add wanda base * Initial implementation * Update Wanda Base * Refactor to use WandaLayerCompressor Update WrappedGPT * Rename WrappedGPT to WandaGPT * [Wanda Refactor] Wanda/OBCQ Modifier Refactor (#1887) * Define GPT contract * rename tmp -> batch_size * Define LayerCompressor Contract * Rename gpt_helpers to gpts Fix some docstrings * add named argument to function call * Wanda/OBCQ refactor * propagate target-ids * Address review comments from * #1885 * #1886 * Fix typo * Update test * Fix regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines a LayerCompressor contract; similar to #1885 to remove some code redundancy, and is the second piece pertaining to WandaRefactor; the last remaining piece is to Update Wanda and OBCQ modifier to share code.