[Wanda Refactor] TerminalModuleCompressor contract
#1885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Satrat
approved these changes
Dec 7, 2023
Done! |
bfineran
reviewed
Dec 11, 2023
| torch.backends.cudnn.allow_tf32 = False | ||
|
|
||
|
|
||
| class TerminalModuleCompressor(ABC): |
There was a problem hiding this comment.
would be good to get rid of this since we just have 1 implementor class and don't expect any in the near future
rahul-tuli
force-pushed
the
define-gpt-contract
branch
from
86bbaed
to
c6f9ab0
Compare
rahul-tuli
changed the title
TerminalModuleCompressor contract
rahul-tuli
added a commit
that referenced
this pull request
Dec 18, 2023
|
Closingg cause requested updates are now a part of #1887 |
rahul-tuli
added a commit
that referenced
this pull request
Dec 28, 2023
* Add wanda base * Initial implementation * Update Wanda Base * Refactor to use WandaLayerCompressor Update WrappedGPT * Rename WrappedGPT to WandaGPT * [Wanda Refactor] Wanda/OBCQ Modifier Refactor (#1887) * Define GPT contract * rename tmp -> batch_size * Define LayerCompressor Contract * Rename gpt_helpers to gpts Fix some docstrings * add named argument to function call * Wanda/OBCQ refactor * propagate target-ids * Address review comments from * #1885 * #1886 * Fix typo * Update test * Fix regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some code duplicacy b/w SparseGPT and WandaGPT by defining a contract and Moving common functionality to a base class
Subsequent diffs will do similar refactor for LayerCompressor and the actual WandaModifier