[OBCQ Recipe UX Change] Remove target_ids #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmarques
reviewed
Nov 1, 2023
dsikka
reviewed
Nov 1, 2023
|
LGTM pending the other PR comments, I agree having a list of default ids would be useful |
* Make default target ids a global * use named arguments
dbogunowicz
approved these changes
Nov 13, 2023
Satrat
approved these changes
Nov 13, 2023
bfineran
pushed a commit
that referenced
this pull request
Nov 16, 2023
* Remove target_ids * Define target ids based on inputs * Fix cache * Remove remaining instances of target_ids * Address review comments! * Make default target ids a global * use named arguments
bfineran
pushed a commit
that referenced
this pull request
Nov 16, 2023
* Remove target_ids * Define target ids based on inputs * Fix cache * Remove remaining instances of target_ids * Address review comments! * Make default target ids a global * use named arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes target_ids param from OBCQ modifier; now this param is not needed and will be inferred automatically
Test plan: Run obcq on both llama, and opt-1.3b; and assert we do not drop in perplexity
Expected perplexity:
Test commands:
Output: (Truncated)
Output: (Truncated)
Changes in existing recipes: Look at example.yaml/example_llama.yaml but TLDR; just remove target_ids field altogether