[OBCQ][UX update] Make target ids optional #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbogunowicz
approved these changes
Nov 13, 2023
bfineran
approved these changes
Nov 13, 2023
bfineran
pushed a commit
that referenced
this pull request
Nov 16, 2023
* Make target_ids optional as request by MLR * Use named arguments
bfineran
pushed a commit
that referenced
this pull request
Nov 16, 2023
* Make target_ids optional as request by MLR * Use named arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target_idswas deprecated in a previous PR #1804 ; in hindsight it would be nicer to make it optional to allow easier transition for users(credits to @anmarques). This PR does that. With this change older recipes (with target_ids specified) would also work and log a warning saying this param is deprecated and would be removed completely in a future release.The same test was run as in #1804 and same results were observed