Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OBCQ Recipe UX Change] Remove target_ids #1804

Merged
merged 7 commits into from
Nov 13, 2023
Merged

[OBCQ Recipe UX Change] Remove target_ids #1804

merged 7 commits into from
Nov 13, 2023

Commits on Oct 31, 2023

  1. Remove target_ids

    @rahul-tuli
    rahul-tuli committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    f8c186e View commit details
    Browse the repository at this point in the history

  2. Define target ids based on inputs

    @rahul-tuli
    rahul-tuli committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    9aa1453 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Fix cache

    @rahul-tuli
    rahul-tuli committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    7ebc998 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into remove-target-id

    @rahul-tuli
    rahul-tuli committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    3012595 View commit details
    Browse the repository at this point in the history

  3. Remove remaining instances of target_ids

    @rahul-tuli
    rahul-tuli committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    b1b2526 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Merge branch 'main' into remove-target-id

    @rahul-tuli
    rahul-tuli committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    610f684 View commit details
    Browse the repository at this point in the history

  2. Address review comments! 

    * Make default target ids a global
* use named arguments
    @rahul-tuli
    rahul-tuli committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    56dcf1a View commit details
    Browse the repository at this point in the history