Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: XLogFlush replication slot save/drop #396

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Mar 20, 2024

No description provided.

@skyzh skyzh requested a review from knizhnik March 20, 2024 20:21
@skyzh skyzh changed the title fix: XLogFlush replication slot drop fix: XLogFlush replication slot save/drop Mar 20, 2024
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/flush-drop-replication-pg14 branch from 3ca03cc to 1bea0ea Compare March 25, 2024 14:45
@skyzh skyzh merged commit a7b4c66 into REL_14_STABLE_neon Mar 28, 2024
@skyzh skyzh deleted the skyzh/flush-drop-replication-pg14 branch March 28, 2024 14:42
skyzh added a commit to neondatabase/neon that referenced this pull request Mar 28, 2024
Fix #6969

Ref neondatabase/postgres#395
neondatabase/postgres#396

Postgres will stuck on exit if the replication slot is not dropped
before shutting down. This is caused by Neon's custom WAL record to
record replication slots. The pull requests in the postgres repo fixes
the problem, and this pull request bumps the postgres commit.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
tristan957 pushed a commit that referenced this pull request May 10, 2024
Signed-off-by: Alex Chi Z <chi@neon.tech>
tristan957 pushed a commit that referenced this pull request May 20, 2024
Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants