Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: XLogFlush replication slot save/drop #395

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Mar 20, 2024

Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/flush-drop-replication branch from 3ef27b3 to dc78604 Compare March 25, 2024 14:45
@skyzh skyzh merged commit 64b8c7b into REL_15_STABLE_neon Mar 28, 2024
@skyzh skyzh deleted the skyzh/flush-drop-replication branch March 28, 2024 14:41
skyzh added a commit to neondatabase/neon that referenced this pull request Mar 28, 2024
Fix #6969

Ref neondatabase/postgres#395
neondatabase/postgres#396

Postgres will stuck on exit if the replication slot is not dropped
before shutting down. This is caused by Neon's custom WAL record to
record replication slots. The pull requests in the postgres repo fixes
the problem, and this pull request bumps the postgres commit.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
tristan957 pushed a commit that referenced this pull request May 10, 2024
…ion position in wal_proppser to segment boundary
tristan957 pushed a commit that referenced this pull request May 10, 2024
* fix: XLogFlush replication slot drop

Signed-off-by: Alex Chi Z <chi@neon.tech>

* fix all occurrences

Signed-off-by: Alex Chi Z <chi@neon.tech>

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
tristan957 pushed a commit that referenced this pull request May 20, 2024
* fix: XLogFlush replication slot drop

Signed-off-by: Alex Chi Z <chi@neon.tech>

* fix all occurrences

Signed-off-by: Alex Chi Z <chi@neon.tech>

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
poojanilangekar pushed a commit to umd-dslam/sunstorm-postgres that referenced this pull request Aug 26, 2024
…art replication position in wal_proppser to segment boundary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants