Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop replication slot causes postgres stuck on exit #7192

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Mar 20, 2024

Problem

Fix #6969

Ref neondatabase/postgres#395 neondatabase/postgres#396

Postgres will stuck on exit if the replication slot is not dropped before shutting down. This is caused by Neon's custom WAL record to record replication slots. The pull requests in the postgres repo fixes the problem, and this pull request bumps the postgres commit.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Mar 20, 2024

2742 tests run: 2602 passed, 0 failed, 140 skipped (full report)


Code coverage* (full report)

  • functions: 28.2% (6331 of 22466 functions)
  • lines: 47.0% (44530 of 94659 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
bd96ac4 at 2024-03-28T15:32:54.044Z :recycle:

@skyzh skyzh marked this pull request as ready for review March 25, 2024 13:36
@skyzh skyzh requested a review from a team as a code owner March 25, 2024 13:36
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh enabled auto-merge (squash) March 28, 2024 14:44
@skyzh skyzh disabled auto-merge March 28, 2024 14:44
@skyzh skyzh enabled auto-merge (squash) March 28, 2024 14:44
@skyzh skyzh merged commit be1d8fc into main Mar 28, 2024
43 checks passed
@skyzh skyzh deleted the skyzh/fix-6969 branch March 28, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test: test_neon_superuser / pg15-release cannot properly exit when replication is enabled
2 participants