pageserver: move page_service
's import basebackup
/ import wal
to mgmt API
#8292
+301
−408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to fix bugs in
page_service
(issue) and theimport basebackup
/import wal
stand in the way / make the refactoring more complicated.We don't use these methods anyway in practice, but, there have been some objections to removing the functionality completely.
So, this PR preserves the existing functionality but moves it into the HTTP management API.
Note that I don't try to fix existing bugs in the code, specifically not fixing
All errors are mapped to
ApiError::InternalServerError
.