Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: move page_service's import basebackup / import wal to mgmt API #8292

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

problame
Copy link
Contributor

@problame problame commented Jul 5, 2024

I want to fix bugs in page_service (issue) and the import basebackup / import wal stand in the way / make the refactoring more complicated.

We don't use these methods anyway in practice, but, there have been some objections to removing the functionality completely.

So, this PR preserves the existing functionality but moves it into the HTTP management API.

Note that I don't try to fix existing bugs in the code, specifically not fixing

  • it only ever worked correctly for unsharded tenants
  • it doesn't clean up on error

All errors are mapped to ApiError::InternalServerError.

@problame problame force-pushed the problame/move-import-basebackup-and-wal-to-mgmt-api branch from 2b67fab to 544dd1e Compare July 5, 2024 19:05
Copy link

github-actions bot commented Jul 5, 2024

3042 tests run: 2927 passed, 0 failed, 115 skipped (full report)


Flaky tests (5)

Postgres 16

  • test_ondemand_wal_download_in_replication_slot_funcs: release

Postgres 15

  • test_isolation[None]: debug

Postgres 14

  • test_background_operation_cancellation: release
  • test_subscriber_restart: release
  • test_tenant_creation_fails: debug

Code coverage* (full report)

  • functions: 32.6% (6931 of 21277 functions)
  • lines: 50.0% (54483 of 109016 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
21ebb69 at 2024-07-05T20:56:28.874Z :recycle:

@problame problame marked this pull request as ready for review July 5, 2024 20:03
@problame problame requested a review from a team as a code owner July 5, 2024 20:03
@problame problame requested review from yliang412 and jcsp July 5, 2024 20:03
Copy link
Contributor

@yliang412 yliang412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@problame
Copy link
Contributor Author

problame commented Jul 9, 2024

Waiting for review from team compute https://neondb.slack.com/archives/C04DGM6SMTM/p1720542945296569

Copy link
Contributor

@hlinnaka hlinnaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. We might need to bring this back later, perhaps in a new HTTP-based API that's exposed to computes or something. But let's cross that bridge when we get there. In the meanwhile, it's good to keep the API surface as small as possible.

@problame problame merged commit 1a49f1c into main Jul 9, 2024
66 checks passed
@problame problame deleted the problame/move-import-basebackup-and-wal-to-mgmt-api branch July 9, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants