Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_import_from_vanilla is flaky #7147

Closed
arssher opened this issue Mar 15, 2024 · 4 comments
Closed

test_import_from_vanilla is flaky #7147

arssher opened this issue Mar 15, 2024 · 4 comments
Labels
a/test/flaky Area: related to flaky tests

Comments

@arssher
Copy link
Contributor

arssher commented Mar 15, 2024

https://neon-github-public-dev.s3.amazonaws.com/reports/pr-7143/8298321416/index.html#suites/89cfa994d71769e01e3fc4f475a1f3fa/3808ea35562dfa83


The above exception was the direct cause of the following exception:
test_runner/regress/test_import.py:150: in test_import_from_vanilla
    endpoint = env.endpoints.create_start(endpoint_id, tenant_id=tenant)
test_runner/fixtures/neon_fixtures.py:3451: in create_start
    return ep.create_start(
test_runner/fixtures/neon_fixtures.py:3391: in create_start
    self.create(
test_runner/fixtures/neon_fixtures.py:3249: in start
    self.env.neon_cli.endpoint_start(
test_runner/fixtures/neon_fixtures.py:1827: in endpoint_start
    res = self.raw_cli(args)
test_runner/fixtures/neon_fixtures.py:1519: in raw_cli
    return super().raw_cli(*args, **kwargs)
test_runner/fixtures/neon_fixtures.py:1503: in raw_cli
    raise RuntimeError(msg) from subprocess.CalledProcessError(
E   RuntimeError: Run ['/tmp/neon/bin/neon_local', 'endpoint', 'start', '--safekeepers', '1', 'ep-1'] failed:
E     stdout:
E   
E     stderr:
E       command failed: attempting to create a duplicate primary endpoint on tenant 61758837be82ef7593354b91ed8cf9e7, timeline 464719c0b20bb10ca55be51aae859084: endpoint "ep-import_from_vanilla" exists already. please don't do this, it is not supported.
E   
E       Stack backtrace:
E          0: anyhow::__private::format_err
E                    at .cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.71/src/lib.rs:672:13
E          1: <control_plane::endpoint::ComputeControlPlane>::check_conflicting_endpoints
E                    at control_plane/src/endpoint.rs:197:17
E          2: neon_local::handle_endpoint::{closure#0}
E                    at control_plane/src/bin/neon_local.rs:947:13

@arssher arssher added the a/test/flaky Area: related to flaky tests label Mar 15, 2024
@hlinnaka
Copy link
Contributor

@knizhnik
Copy link
Contributor

happened again: https://github.com/neondatabase/neon/actions/runs/8836347617/job/24263181873?pr=7377

Sorry, may be I missed something, but following this link I found failed test_vm_bit_clear_on_heap_lock failure.
It is different flacky test. Did you see my PR: #7499 ?

@hlinnaka
Copy link
Contributor

Oh you're right, that's what caused the failure in this case. I saw that message scroll by in the log as it was still running, and assumed that's what what caused the failure.

There are a bunch of those "Attempting to create a duplicate primary endpoint on tenant" errors in the log, but I guess they didn't make it fail? They're from different tests:

  • in test_neon_two_primary_endpoints_fail[debug-pg16]. I didn't look at what it does, but based on the test name, I guess that's normal
  • test_concurrent_computes[debug-pg16]. Also normal maybe?

@problame
Copy link
Contributor

problame commented Jul 9, 2024

test_import_from_vanilla hasn't been flaky in the last 7 days, probably for much longer. Closing this.

(Came across this while working on

@problame problame closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/test/flaky Area: related to flaky tests
Projects
None yet
Development

No branches or pull requests

4 participants