-
Notifications
You must be signed in to change notification settings - Fork 393
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
pageserver: move
page_service
's import basebackup
/ import wal
…
…to mgmt API (#8292) I want to fix bugs in `page_service` ([issue](#7427)) and the `import basebackup` / `import wal` stand in the way / make the refactoring more complicated. We don't use these methods anyway in practice, but, there have been some objections to removing the functionality completely. So, this PR preserves the existing functionality but moves it into the HTTP management API. Note that I don't try to fix existing bugs in the code, specifically not fixing * it only ever worked correctly for unsharded tenants * it doesn't clean up on error All errors are mapped to `ApiError::InternalServerError`.
- Loading branch information
Showing
11 changed files
with
301 additions
and
408 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
1a49f1c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3129 tests run: 3001 passed, 1 failed, 127 skipped (full report)
Failures on Postgres 14
test_sharding_autosplit[github-actions-selfhosted]
: releaseFlaky tests (3)
Postgres 15
test_isolation[None]
: debugtest_tenant_creation_fails
: debugPostgres 14
test_isolation[None]
: debugCode coverage* (full report)
functions
:32.6% (6941 of 21294 functions)
lines
:50.0% (54551 of 109142 lines)
* collected from Rust tests only
1a49f1c at 2024-07-09T22:39:15.006Z :recycle: