Skip to content

Commit

Permalink
Make 'neon.protocol_version = 2' the default, take two (#7819)
Browse files Browse the repository at this point in the history
Once all the computes in production have restarted, we can remove
protocol version 1 altogether.

See issue #6211.

This was done earlier already in commit 0115fe6, but reverted before
it was released to production in commit bbe730d because of issue
#7692. That issue was fixed
in commit 22afaea, so we are ready to change the default again.
  • Loading branch information
hlinnaka committed May 22, 2024
1 parent 9217564 commit 37f8128
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pgxn/neon/libpagestore.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ char *neon_auth_token;
int readahead_buffer_size = 128;
int flush_every_n_requests = 8;

int neon_protocol_version = 1;
int neon_protocol_version = 2;

static int n_reconnect_attempts = 0;
static int max_reconnect_attempts = 60;
Expand Down Expand Up @@ -860,7 +860,7 @@ pg_init_libpagestore(void)
"Version of compute<->page server protocol",
NULL,
&neon_protocol_version,
1, /* default to old protocol for now */
2, /* use protocol version 2 */
1, /* min */
2, /* max */
PGC_SU_BACKEND,
Expand Down

1 comment on commit 37f8128

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3196 tests run: 3055 passed, 1 failed, 140 skipped (full report)


Failures on Postgres 14

  • test_storage_controller_many_tenants[github-actions-selfhosted]: release
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_storage_controller_many_tenants[release-pg14-github-actions-selfhosted]"
Flaky tests (2)

Postgres 15

  • test_synthetic_size_while_deleting: release

Postgres 14

Code coverage* (full report)

  • functions: 31.3% (6414 of 20477 functions)
  • lines: 48.0% (49313 of 102645 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
37f8128 at 2024-05-22T17:07:40.998Z :recycle:

Please sign in to comment.