Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert protocol version upgrade (#7727)
## Problem "John pointed out that the switch to protocol version 2 made test_gc_aggressive test flaky: #7692. I tracked it down, and that is indeed an issue. Conditions for hitting the issue: The problem occurs in the primary GC horizon is set to a very low value, e.g. 0. If the primary is actively writing WAL, and GC runs in the pageserver at the same time that the primary sends a GetPage request, it's possible that the GC advances the GC horizon past the GetPage request's LSN. I'm working on a fix here: #7708." - Heikki ## Summary of changes Use protocol version 1 as default.
- Loading branch information
bbe730d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3141 tests run: 2995 passed, 0 failed, 146 skipped (full report)
Code coverage* (full report)
functions
:31.4% (6329 of 20161 functions)
lines
:47.3% (47744 of 100969 lines)
* collected from Rust tests only
bbe730d at 2024-05-13T14:14:10.464Z :recycle: