Skip to content

Commit

Permalink
Make 'neon.protocol_version = 2' the default (#7616)
Browse files Browse the repository at this point in the history 
Once all the computes in production have restarted, we can remove
protocol version 1 altogether.

See issue #6211.
  • Loading branch information
@hlinnaka
hlinnaka committed May 6, 2024
1 parent e6da7e2 commit 0115fe6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pgxn/neon/libpagestore.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ char *neon_auth_token;
int readahead_buffer_size = 128;
int flush_every_n_requests = 8;

int neon_protocol_version = 1;
int neon_protocol_version = 2;

static int n_reconnect_attempts = 0;
static int max_reconnect_attempts = 60;
Expand Down Expand Up @@ -860,7 +860,7 @@ pg_init_libpagestore(void)
"Version of compute<->page server protocol",
NULL,
&neon_protocol_version,
1, /* default to old protocol for now */
2, /* use protocol version 2 */
1, /* min */
2, /* max */
PGC_SU_BACKEND,
Expand Down

1 comment on commit 0115fe6

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2961 tests run: 2824 passed, 3 failed, 134 skipped (full report)

Failures on Postgres 14

  • test_storage_controller_many_tenants[github-actions-selfhosted]: release
  • test_bulk_tenant_create[github-actions-selfhosted-5]: release
  • test_bulk_tenant_create[github-actions-selfhosted-10]: release
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_storage_controller_many_tenants[release-pg14-github-actions-selfhosted] or test_bulk_tenant_create[release-pg14-github-actions-selfhosted-5] or test_bulk_tenant_create[release-pg14-github-actions-selfhosted-10]"
Flaky tests (1)

Postgres 16

  • test_scrubber_tenant_snapshot[4]: release

Code coverage* (full report)

  • functions: 31.4% (6236 of 19852 functions)
  • lines: 47.1% (46718 of 99133 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
0115fe6 at 2024-05-06T13:15:23.543Z :recycle:

Please sign in to comment.