update version to 2021.6.99 to be able to filter #6122

DavidKutu · 2021-06-03T22:37:08Z

also updated changelog

Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
Title summarizes what is changing.
Has a news entry file (remember to thank yourself!).
Appropriate comments and documentation strings in the code.
Has sufficient logging.
Has telemetry for enhancements.
Unit tests & system/integration tests are added/updated.
Test plan is updated as appropriate.
package-lock.json has been regenerated by running npm install (if dependencies have changed).

update changelog

rchiodo · 2021-06-03T22:48:38Z

src/client/datascience/notebook/vscodeNotebookController.ts

@@ -109,7 +109,7 @@ export class VSCodeNotebookController implements Disposable {
        this.controller.supportsExecutionOrder = true;
        this.controller.supportedLanguages = this.languageService.getSupportedLanguages(kernelConnection);
        // Hook up to see when this NotebookController is selected by the UI
-        this.controller.onDidChangeNotebookAssociation(this.onDidChangeNotebookAssociation, this, this.disposables);
+        this.controller.onDidChangeSelectedNotebooks(this.onDidChangeSelectedNotebooks, this, this.disposables);


Merge problems?

DonJayamanne · 2021-06-03T22:51:30Z

package.json

@@ -1,7 +1,7 @@
 {
    "name": "jupyter",
    "displayName": "Jupyter",
-    "version": "2021.6.1-rc",
+    "version": "2021.6.99-rc",


I don't think this will work. we have code that updates this with the build number.
Please check the generated VSIX

codecov-commenter · 2021-06-03T23:10:10Z

Codecov Report

❗ No coverage uploaded for pull request base (release-2021.06@d71f56e). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release-2021.06   #6122   +/-   ##
=================================================
  Coverage                   ?     68%           
=================================================
  Files                      ?     398           
  Lines                      ?   26812           
  Branches                   ?    3939           
=================================================
  Hits                       ?   18367           
  Misses                     ?    6919           
  Partials                   ?    1526

* release candidate (#6059) * release candidate * Memorial Day API changes (#6056) * update changelog Co-authored-by: Ian Huff <ianhu@microsoft.com> * Memorial Day API changes (#6056) * Send only error type in reason (#6067) * Fallback for sys.prefix not being returned by Python extension (#6053) * Fixes to toggling output (#6068) * Better telemetry when we don't find a matching kernel (#6060) * Better data when fail to find kernel connection (#6070) * change version and API port (#6085) * change version to 2021.6.x * match packagejson and changelog versions * 6/2 API Changes (#6089) Co-authored-by: Ian Huff <ianhu@microsoft.com> * Port #6025 to release (#6103) * Remove our Run Above/Below commands (#6026) * Update changelog * Fix pervasive test issue with editor properties (#6100) (#6106) * update version to 2021.6.99 to be able to filter (#6122) * update version to 2021.6.99 to be able to filter update changelog * update package lock and VSCode api * don * remove api changes in the code * Port Don's fixes (#6115) * Fix test failures resulting from VSCodes Notebook Start page (#6111) * Disable kernel auto startup in untrusted workspace (#6088) * Disable kernel auto startup in untrusted workspace * Fixes * Misc * oops * misc * Fixes to breaking tests (#6074) Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> * Breaking changes ports to release (2 commits) (#6140) * add component governance file (#6166) * add component governance file * remove npm components * Cherry pick changes from main branch into release (#6174) * final update (#6176) * final update * update changelog * update verion, engine revert change on gulpfile * merge main * revert engine to 1.57-insider * delete news files that are on the changelog * disable insiders build Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

* release candidate (#6059) * release candidate * Memorial Day API changes (#6056) * update changelog Co-authored-by: Ian Huff <ianhu@microsoft.com> * Memorial Day API changes (#6056) * Send only error type in reason (#6067) * Fallback for sys.prefix not being returned by Python extension (#6053) * Fixes to toggling output (#6068) * Better telemetry when we don't find a matching kernel (#6060) * Better data when fail to find kernel connection (#6070) * change version and API port (#6085) * change version to 2021.6.x * match packagejson and changelog versions * 6/2 API Changes (#6089) Co-authored-by: Ian Huff <ianhu@microsoft.com> * Port #6025 to release (#6103) * Remove our Run Above/Below commands (#6026) * Update changelog * Fix pervasive test issue with editor properties (#6100) (#6106) * update version to 2021.6.99 to be able to filter (#6122) * update version to 2021.6.99 to be able to filter update changelog * update package lock and VSCode api * don * remove api changes in the code * Port Don's fixes (#6115) * Fix test failures resulting from VSCodes Notebook Start page (#6111) * Disable kernel auto startup in untrusted workspace (#6088) * Disable kernel auto startup in untrusted workspace * Fixes * Misc * oops * misc * Fixes to breaking tests (#6074) Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> * Breaking changes ports to release (2 commits) (#6140) * add component governance file (#6166) * add component governance file * remove npm components * Cherry pick changes from main branch into release (#6174) * final update (#6176) * final update * update changelog * add missing thanks to changelog (#6197) * Skip uploading vsix to azure blob store (#6204) * publish release * publish release * remove last 2 numbers from release (#6219) * publish release * fix conflicts * update engine to 1.58.0-insider * return engine version to 1.57.0-insider * Do not activate Python before opening nb (#6201) (#6230) * publish release Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

* release candidate (#6059) * release candidate * Memorial Day API changes (#6056) * update changelog Co-authored-by: Ian Huff <ianhu@microsoft.com> * Memorial Day API changes (#6056) * Send only error type in reason (#6067) * Fallback for sys.prefix not being returned by Python extension (#6053) * Fixes to toggling output (#6068) * Better telemetry when we don't find a matching kernel (#6060) * Better data when fail to find kernel connection (#6070) * change version and API port (#6085) * change version to 2021.6.x * match packagejson and changelog versions * 6/2 API Changes (#6089) Co-authored-by: Ian Huff <ianhu@microsoft.com> * Port #6025 to release (#6103) * Remove our Run Above/Below commands (#6026) * Update changelog * Fix pervasive test issue with editor properties (#6100) (#6106) * update version to 2021.6.99 to be able to filter (#6122) * update version to 2021.6.99 to be able to filter update changelog * update package lock and VSCode api * don * remove api changes in the code * Port Don's fixes (#6115) * Fix test failures resulting from VSCodes Notebook Start page (#6111) * Disable kernel auto startup in untrusted workspace (#6088) * Disable kernel auto startup in untrusted workspace * Fixes * Misc * oops * misc * Fixes to breaking tests (#6074) Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> * Breaking changes ports to release (2 commits) (#6140) * add component governance file (#6166) * add component governance file * remove npm components * Cherry pick changes from main branch into release (#6174) * final update (#6176) * final update * update changelog * add missing thanks to changelog (#6197) * Skip uploading vsix to azure blob store (#6204) * publish release * publish release * remove last 2 numbers from release (#6219) * publish release * Do not activate Python before opening nb (#6201) (#6230) * publish release * Port LiveKernelModel fix to release for point release (#6264) * Port keybinding updates to release (#6268) * Contribute shift+enter, ctrl+enter, L, shift+L (#6205) * Ctrl+Enter should put cell into command mode after executing (#6231) * Update CHANGELOG and remove news * port test fix (#6275) * Fix Restarting kernel... test (#6267) * wait for the restart command * add news file * update changelog * Fix native notebook interrupt toolbar (#6280) (#6282) * update changelog (#6284) * -update version -update changelog * leave version as it was * Respect jupyter.enableKeyboardShortcuts setting and enable ctrl+enter in command mode (#6293) * publish release * fix gulpfile * undo change Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

update version to 2021.6.99 to be able to filter

6f2fb71

update changelog

DavidKutu requested a review from a team as a code owner June 3, 2021 22:37

DavidKutu changed the title ~~update version to 2021.6.99 to be able to filter update changelog~~ update version to 2021.6.99 to be able to filter Jun 3, 2021

update package lock and VSCode api

06115f8

rchiodo reviewed Jun 3, 2021

View reviewed changes

rchiodo approved these changes Jun 3, 2021

View reviewed changes

DonJayamanne requested changes Jun 3, 2021

View reviewed changes

David added 2 commits June 3, 2021 16:22

don

0745bda

remove api changes in the code

fb5b5a2

DavidKutu requested a review from DonJayamanne June 3, 2021 23:24

DonJayamanne approved these changes Jun 3, 2021

View reviewed changes

DavidKutu merged commit f8f7907 into release-2021.06 Jun 3, 2021

DavidKutu deleted the david/changeVersionNumber branch June 3, 2021 23:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update version to 2021.6.99 to be able to filter #6122

update version to 2021.6.99 to be able to filter #6122

DavidKutu commented Jun 3, 2021 •

edited

Loading

rchiodo Jun 3, 2021

DonJayamanne Jun 3, 2021

codecov-commenter commented Jun 3, 2021

update version to 2021.6.99 to be able to filter #6122

update version to 2021.6.99 to be able to filter #6122

Conversation

DavidKutu commented Jun 3, 2021 • edited Loading

rchiodo Jun 3, 2021

Choose a reason for hiding this comment

DonJayamanne Jun 3, 2021

Choose a reason for hiding this comment

codecov-commenter commented Jun 3, 2021

Codecov Report

DavidKutu commented Jun 3, 2021 •

edited

Loading