Memorial Day API changes #6056

IanMatthewHuff · 2021-06-01T21:35:37Z

VS Code made these changes non-breaking so they could check them in on Monday without breaking us. Updating now to catch up.

Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
Title summarizes what is changing.
Has a news entry file (remember to thank yourself!).
Appropriate comments and documentation strings in the code.
Has sufficient logging.
Has telemetry for enhancements.
Unit tests & system/integration tests are added/updated.
Test plan is updated as appropriate.
package-lock.json has been regenerated by running npm install (if dependencies have changed).

IanMatthewHuff · 2021-06-01T21:58:36Z

Whoops, something horked up on the functional tests. Looking now.

codecov-commenter · 2021-06-01T22:00:56Z

Codecov Report

Merging #6056 (d361d3e) into main (197977f) will decrease coverage by 0%.
The diff coverage is 74%.

❗ Current head d361d3e differs from pull request most recent head ea07ada. Consider uploading reports for the commit ea07ada to get more accurate results

@@          Coverage Diff           @@
##            main   #6056    +/-   ##
======================================
- Coverage     72%     72%    -1%     
======================================
  Files        403     398     -5     
  Lines      27130   26840   -290     
  Branches    3975    3946    -29     
======================================
- Hits       19589   19364   -225     
+ Misses      5883    5835    -48     
+ Partials    1658    1641    -17

Impacted Files	Coverage Δ
src/client/common/application/types.ts	`100% <ø> (ø)`
src/client/common/configSettings.ts	`88% <0%> (-2%)`	⬇️
src/client/common/types.ts	`100% <ø> (ø)`
src/client/common/utils/localize.ts	`95% <ø> (-1%)`	⬇️
src/client/datascience/constants.ts	`99% <ø> (-1%)`	⬇️
...ient/datascience/editor-integration/codewatcher.ts	`69% <0%> (-1%)`	⬇️
...ience/interactive-common/interactiveWindowTypes.ts	`100% <ø> (ø)`
.../datascience/interactive-common/synchronization.ts	`84% <ø> (ø)`
...cience/interactive-ipynb/nativeEditorOldWebView.ts	`85% <ø> (ø)`
...ience/interactive-ipynb/nativeEditorProviderOld.ts	`74% <ø> (ø)`
... and 41 more

IanMatthewHuff · 2021-06-01T23:28:22Z

I'm still doing a bit of manual poking (display_data, originalError, needs_background), but requesting re-review due to me adding in the metadata breaking changes. Would rather have the reviews in earlier versus later so I can submit to keep the build clean. Currently testing by building main from vscode. @DonJayamanne @rchiodo @DavidKutu .

rchiodo · 2021-06-01T23:38:47Z

src/client/datascience/notebook/helpers/helpers.ts

@@ -556,19 +533,7 @@ function translateDisplayDataOutput(
    const data: Record<string, any> = output.data || {};
    // eslint-disable-next-line
    for (const key in data) {
-        // Add metadata to all (its the same)
-        // We can optionally remove metadata that belongs to other mime types (feels like over optimization, hence not doing that).
-        const value = data[key];


Didn't Don just submit this like this morning? Perhaps a merge conflict?

src/test/datascience/notebook/contentProviderMain.vscode.test.ts

IanMatthewHuff · 2021-06-02T00:52:57Z

Test failures all look due to upstream API ordering issues.

* release candidate * Memorial Day API changes (#6056) * update changelog Co-authored-by: Ian Huff <ianhu@microsoft.com>

* release candidate (#6059) * release candidate * Memorial Day API changes (#6056) * update changelog Co-authored-by: Ian Huff <ianhu@microsoft.com> * Memorial Day API changes (#6056) * Send only error type in reason (#6067) * Fallback for sys.prefix not being returned by Python extension (#6053) * Fixes to toggling output (#6068) * Better telemetry when we don't find a matching kernel (#6060) * Better data when fail to find kernel connection (#6070) * change version and API port (#6085) * change version to 2021.6.x * match packagejson and changelog versions * 6/2 API Changes (#6089) Co-authored-by: Ian Huff <ianhu@microsoft.com> * Port #6025 to release (#6103) * Remove our Run Above/Below commands (#6026) * Update changelog * Fix pervasive test issue with editor properties (#6100) (#6106) * update version to 2021.6.99 to be able to filter (#6122) * update version to 2021.6.99 to be able to filter update changelog * update package lock and VSCode api * don * remove api changes in the code * Port Don's fixes (#6115) * Fix test failures resulting from VSCodes Notebook Start page (#6111) * Disable kernel auto startup in untrusted workspace (#6088) * Disable kernel auto startup in untrusted workspace * Fixes * Misc * oops * misc * Fixes to breaking tests (#6074) Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> * Breaking changes ports to release (2 commits) (#6140) * add component governance file (#6166) * add component governance file * remove npm components * Cherry pick changes from main branch into release (#6174) * final update (#6176) * final update * update changelog * update verion, engine revert change on gulpfile * merge main * revert engine to 1.57-insider * delete news files that are on the changelog * disable insiders build Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

* release candidate (#6059) * release candidate * Memorial Day API changes (#6056) * update changelog Co-authored-by: Ian Huff <ianhu@microsoft.com> * Memorial Day API changes (#6056) * Send only error type in reason (#6067) * Fallback for sys.prefix not being returned by Python extension (#6053) * Fixes to toggling output (#6068) * Better telemetry when we don't find a matching kernel (#6060) * Better data when fail to find kernel connection (#6070) * change version and API port (#6085) * change version to 2021.6.x * match packagejson and changelog versions * 6/2 API Changes (#6089) Co-authored-by: Ian Huff <ianhu@microsoft.com> * Port #6025 to release (#6103) * Remove our Run Above/Below commands (#6026) * Update changelog * Fix pervasive test issue with editor properties (#6100) (#6106) * update version to 2021.6.99 to be able to filter (#6122) * update version to 2021.6.99 to be able to filter update changelog * update package lock and VSCode api * don * remove api changes in the code * Port Don's fixes (#6115) * Fix test failures resulting from VSCodes Notebook Start page (#6111) * Disable kernel auto startup in untrusted workspace (#6088) * Disable kernel auto startup in untrusted workspace * Fixes * Misc * oops * misc * Fixes to breaking tests (#6074) Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> * Breaking changes ports to release (2 commits) (#6140) * add component governance file (#6166) * add component governance file * remove npm components * Cherry pick changes from main branch into release (#6174) * final update (#6176) * final update * update changelog * add missing thanks to changelog (#6197) * Skip uploading vsix to azure blob store (#6204) * publish release * publish release * remove last 2 numbers from release (#6219) * publish release * fix conflicts * update engine to 1.58.0-insider * return engine version to 1.57.0-insider * Do not activate Python before opening nb (#6201) (#6230) * publish release Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

* release candidate (#6059) * release candidate * Memorial Day API changes (#6056) * update changelog Co-authored-by: Ian Huff <ianhu@microsoft.com> * Memorial Day API changes (#6056) * Send only error type in reason (#6067) * Fallback for sys.prefix not being returned by Python extension (#6053) * Fixes to toggling output (#6068) * Better telemetry when we don't find a matching kernel (#6060) * Better data when fail to find kernel connection (#6070) * change version and API port (#6085) * change version to 2021.6.x * match packagejson and changelog versions * 6/2 API Changes (#6089) Co-authored-by: Ian Huff <ianhu@microsoft.com> * Port #6025 to release (#6103) * Remove our Run Above/Below commands (#6026) * Update changelog * Fix pervasive test issue with editor properties (#6100) (#6106) * update version to 2021.6.99 to be able to filter (#6122) * update version to 2021.6.99 to be able to filter update changelog * update package lock and VSCode api * don * remove api changes in the code * Port Don's fixes (#6115) * Fix test failures resulting from VSCodes Notebook Start page (#6111) * Disable kernel auto startup in untrusted workspace (#6088) * Disable kernel auto startup in untrusted workspace * Fixes * Misc * oops * misc * Fixes to breaking tests (#6074) Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> * Breaking changes ports to release (2 commits) (#6140) * add component governance file (#6166) * add component governance file * remove npm components * Cherry pick changes from main branch into release (#6174) * final update (#6176) * final update * update changelog * add missing thanks to changelog (#6197) * Skip uploading vsix to azure blob store (#6204) * publish release * publish release * remove last 2 numbers from release (#6219) * publish release * Do not activate Python before opening nb (#6201) (#6230) * publish release * Port LiveKernelModel fix to release for point release (#6264) * Port keybinding updates to release (#6268) * Contribute shift+enter, ctrl+enter, L, shift+L (#6205) * Ctrl+Enter should put cell into command mode after executing (#6231) * Update CHANGELOG and remove news * port test fix (#6275) * Fix Restarting kernel... test (#6267) * wait for the restart command * add news file * update changelog * Fix native notebook interrupt toolbar (#6280) (#6282) * update changelog (#6284) * -update version -update changelog * leave version as it was * Respect jupyter.enableKeyboardShortcuts setting and enable ctrl+enter in command mode (#6293) * publish release * fix gulpfile * undo change Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

Ian Huff added 3 commits June 1, 2021 14:24

viewType => notebookType change

fbb3aa4

notebook => notebooks rename

d53f3e0

add news

85b02fb

IanMatthewHuff requested a review from a team as a code owner June 1, 2021 21:35

rchiodo approved these changes Jun 1, 2021

View reviewed changes

DonJayamanne approved these changes Jun 1, 2021

View reviewed changes

DavidKutu approved these changes Jun 1, 2021

View reviewed changes

Ian Huff added 5 commits June 1, 2021 15:07

update func test mock

14f42ce

first stab at metadata changes. Just building, need to test

4449b5b

merge with main

d5fba25

remove comments

fdd8dd8

prettier

d361d3e

IanMatthewHuff requested review from DonJayamanne, DavidKutu and rchiodo June 1, 2021 23:25

DavidKutu approved these changes Jun 1, 2021

View reviewed changes

rchiodo reviewed Jun 1, 2021

View reviewed changes

rchiodo approved these changes Jun 1, 2021

View reviewed changes

DonJayamanne reviewed Jun 2, 2021

View reviewed changes

src/test/datascience/notebook/contentProviderMain.vscode.test.ts Outdated Show resolved Hide resolved

actually call the helper function, luckily the tests caught this

ea07ada

IanMatthewHuff merged commit 6bf9c33 into main Jun 2, 2021

IanMatthewHuff deleted the dev/ianhu/semiAPIChanges branch June 2, 2021 00:53

DavidKutu pushed a commit that referenced this pull request Jun 2, 2021

release candidate (#6059)

ce4ecee

* release candidate * Memorial Day API changes (#6056) * update changelog Co-authored-by: Ian Huff <ianhu@microsoft.com>

DonJayamanne pushed a commit that referenced this pull request Jun 2, 2021

Memorial Day API changes (#6056)

f06514a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Memorial Day API changes #6056

Memorial Day API changes #6056

IanMatthewHuff commented Jun 1, 2021

IanMatthewHuff commented Jun 1, 2021

codecov-commenter commented Jun 1, 2021 •

edited

Loading

IanMatthewHuff commented Jun 1, 2021

rchiodo Jun 1, 2021

IanMatthewHuff commented Jun 2, 2021

Memorial Day API changes #6056

Memorial Day API changes #6056

Conversation

IanMatthewHuff commented Jun 1, 2021

IanMatthewHuff commented Jun 1, 2021

codecov-commenter commented Jun 1, 2021 • edited Loading

Codecov Report

IanMatthewHuff commented Jun 1, 2021

rchiodo Jun 1, 2021

Choose a reason for hiding this comment

IanMatthewHuff commented Jun 2, 2021

codecov-commenter commented Jun 1, 2021 •

edited

Loading