Remove our Run Above/Below commands #6026

joyceerhl · 2021-05-28T17:58:28Z

VS Code has implemented this in core. It's controlled by a setting and disabled by default till Tuesday. This must only be merged on Tuesday.

codecov-commenter · 2021-05-28T19:00:17Z

Codecov Report

Merging #6026 (93e74ca) into main (5c2cf0c) will decrease coverage by 9%.
The diff coverage is 32%.

@@           Coverage Diff           @@
##            main   #6026     +/-   ##
=======================================
- Coverage     71%     62%    -10%     
=======================================
  Files        398     398             
  Lines      26836   26816     -20     
  Branches    3950    3940     -10     
=======================================
- Hits       19254   16814   -2440     
- Misses      5956    8598   +2642     
+ Partials    1626    1404    -222

Impacted Files	Coverage Δ
src/client/datascience/constants.ts	`99% <ø> (-1%)`	⬇️
...ient/datascience/interactive-ipynb/nativeEditor.ts	`69% <ø> (+<1%)`	⬆️
...e/interactive-ipynb/nativeEditorCommandListener.ts	`30% <ø> (-11%)`	⬇️
...lient/datascience/jupyter/kernels/cellExecution.ts	`6% <0%> (-65%)`	⬇️
src/client/datascience/notebook/contentProvider.ts	`48% <0%> (-25%)`	⬇️
...t/datascience/notebook/helpers/executionHelpers.ts	`35% <0%> (-42%)`	⬇️
src/client/datascience/notebook/notebookEditor.ts	`6% <ø> (-28%)`	⬇️
...t/datascience/notebook/vscodeNotebookController.ts	`8% <0%> (-69%)`	⬇️
src/client/datascience/types.ts	`100% <ø> (ø)`
src/client/datascience/utils.ts	`63% <ø> (ø)`
... and 146 more

joyceerhl · 2021-06-01T07:44:55Z

Should we migrate any keybindings that users have customized for our commands since we are deleting them?

IanMatthewHuff · 2021-06-01T14:53:29Z

Should we migrate any keybindings that users have customized for our commands since we are deleting them?

I guess I think this might be more trouble than it's worth. This is native only commands right? For insiders customers it doesn't seem too bad to just have them update. My 2 cents at least. Avoid putting more code in.

rchiodo · 2021-06-01T15:10:39Z

news/1 Enhancements/6025.md

@@ -0,0 +1 @@
+Replace 'Run cells above' and 'Run cell and below' commands and cell toolbar buttons with VS Code's built-in 'Execute Above Cells' and 'Execute Cell And Below' commands and unified run button.


I'm wondering if 'interrupt' is going to work correctly or not. We used to be able to cancel all the queued cells for run all when interrrupting. I'm guessing that doesn't work anymore.

We probably will need some special logic in the executeCell commands to handle it.

joyceerhl · 2021-06-01T16:01:34Z

This is native only commands right?

@IanMatthewHuff yes, but I believe these commands may be available to stable users in native notebooks as well.

…to dev/joyceerhl/remove-run-above-below

* Remove our Run Above/Below commands (#6026) * Update changelog

* release candidate (#6059) * release candidate * Memorial Day API changes (#6056) * update changelog Co-authored-by: Ian Huff <ianhu@microsoft.com> * Memorial Day API changes (#6056) * Send only error type in reason (#6067) * Fallback for sys.prefix not being returned by Python extension (#6053) * Fixes to toggling output (#6068) * Better telemetry when we don't find a matching kernel (#6060) * Better data when fail to find kernel connection (#6070) * change version and API port (#6085) * change version to 2021.6.x * match packagejson and changelog versions * 6/2 API Changes (#6089) Co-authored-by: Ian Huff <ianhu@microsoft.com> * Port #6025 to release (#6103) * Remove our Run Above/Below commands (#6026) * Update changelog * Fix pervasive test issue with editor properties (#6100) (#6106) * update version to 2021.6.99 to be able to filter (#6122) * update version to 2021.6.99 to be able to filter update changelog * update package lock and VSCode api * don * remove api changes in the code * Port Don's fixes (#6115) * Fix test failures resulting from VSCodes Notebook Start page (#6111) * Disable kernel auto startup in untrusted workspace (#6088) * Disable kernel auto startup in untrusted workspace * Fixes * Misc * oops * misc * Fixes to breaking tests (#6074) Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> * Breaking changes ports to release (2 commits) (#6140) * add component governance file (#6166) * add component governance file * remove npm components * Cherry pick changes from main branch into release (#6174) * final update (#6176) * final update * update changelog * update verion, engine revert change on gulpfile * merge main * revert engine to 1.57-insider * delete news files that are on the changelog * disable insiders build Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

* release candidate (#6059) * release candidate * Memorial Day API changes (#6056) * update changelog Co-authored-by: Ian Huff <ianhu@microsoft.com> * Memorial Day API changes (#6056) * Send only error type in reason (#6067) * Fallback for sys.prefix not being returned by Python extension (#6053) * Fixes to toggling output (#6068) * Better telemetry when we don't find a matching kernel (#6060) * Better data when fail to find kernel connection (#6070) * change version and API port (#6085) * change version to 2021.6.x * match packagejson and changelog versions * 6/2 API Changes (#6089) Co-authored-by: Ian Huff <ianhu@microsoft.com> * Port #6025 to release (#6103) * Remove our Run Above/Below commands (#6026) * Update changelog * Fix pervasive test issue with editor properties (#6100) (#6106) * update version to 2021.6.99 to be able to filter (#6122) * update version to 2021.6.99 to be able to filter update changelog * update package lock and VSCode api * don * remove api changes in the code * Port Don's fixes (#6115) * Fix test failures resulting from VSCodes Notebook Start page (#6111) * Disable kernel auto startup in untrusted workspace (#6088) * Disable kernel auto startup in untrusted workspace * Fixes * Misc * oops * misc * Fixes to breaking tests (#6074) Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> * Breaking changes ports to release (2 commits) (#6140) * add component governance file (#6166) * add component governance file * remove npm components * Cherry pick changes from main branch into release (#6174) * final update (#6176) * final update * update changelog * add missing thanks to changelog (#6197) * Skip uploading vsix to azure blob store (#6204) * publish release * publish release * remove last 2 numbers from release (#6219) * publish release * fix conflicts * update engine to 1.58.0-insider * return engine version to 1.57.0-insider * Do not activate Python before opening nb (#6201) (#6230) * publish release Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

* release candidate (#6059) * release candidate * Memorial Day API changes (#6056) * update changelog Co-authored-by: Ian Huff <ianhu@microsoft.com> * Memorial Day API changes (#6056) * Send only error type in reason (#6067) * Fallback for sys.prefix not being returned by Python extension (#6053) * Fixes to toggling output (#6068) * Better telemetry when we don't find a matching kernel (#6060) * Better data when fail to find kernel connection (#6070) * change version and API port (#6085) * change version to 2021.6.x * match packagejson and changelog versions * 6/2 API Changes (#6089) Co-authored-by: Ian Huff <ianhu@microsoft.com> * Port #6025 to release (#6103) * Remove our Run Above/Below commands (#6026) * Update changelog * Fix pervasive test issue with editor properties (#6100) (#6106) * update version to 2021.6.99 to be able to filter (#6122) * update version to 2021.6.99 to be able to filter update changelog * update package lock and VSCode api * don * remove api changes in the code * Port Don's fixes (#6115) * Fix test failures resulting from VSCodes Notebook Start page (#6111) * Disable kernel auto startup in untrusted workspace (#6088) * Disable kernel auto startup in untrusted workspace * Fixes * Misc * oops * misc * Fixes to breaking tests (#6074) Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> * Breaking changes ports to release (2 commits) (#6140) * add component governance file (#6166) * add component governance file * remove npm components * Cherry pick changes from main branch into release (#6174) * final update (#6176) * final update * update changelog * add missing thanks to changelog (#6197) * Skip uploading vsix to azure blob store (#6204) * publish release * publish release * remove last 2 numbers from release (#6219) * publish release * Do not activate Python before opening nb (#6201) (#6230) * publish release * Port LiveKernelModel fix to release for point release (#6264) * Port keybinding updates to release (#6268) * Contribute shift+enter, ctrl+enter, L, shift+L (#6205) * Ctrl+Enter should put cell into command mode after executing (#6231) * Update CHANGELOG and remove news * port test fix (#6275) * Fix Restarting kernel... test (#6267) * wait for the restart command * add news file * update changelog * Fix native notebook interrupt toolbar (#6280) (#6282) * update changelog (#6284) * -update version -update changelog * leave version as it was * Respect jupyter.enableKeyboardShortcuts setting and enable ctrl+enter in command mode (#6293) * publish release * fix gulpfile * undo change Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

Remove our Run Above/Below commands

ea7ef64

joyceerhl requested a review from a team as a code owner May 28, 2021 17:58

joyceerhl added 4 commits May 28, 2021 11:06

Remove unused imports

cb84fdc

Remove another unused import

d324d7c

Run prettier

b370432

Another import

d7e7646

DonJayamanne approved these changes May 28, 2021

View reviewed changes

IanMatthewHuff approved these changes May 29, 2021

View reviewed changes

joyceerhl added 2 commits June 1, 2021 00:31

Oops

14587ac

Add news entry

6246e94

rchiodo reviewed Jun 1, 2021

View reviewed changes

rchiodo approved these changes Jun 1, 2021

View reviewed changes

joyceerhl added 4 commits June 2, 2021 14:03

Merge branch 'main' of https://github.com/microsoft/vscode-jupyter in…

c44d460

…to dev/joyceerhl/remove-run-above-below

Fix lint

63fdd24

Merge branch 'main' of https://github.com/microsoft/vscode-jupyter in…

a4835fa

…to dev/joyceerhl/remove-run-above-below

Merge branch 'main' of https://github.com/microsoft/vscode-jupyter in…

93e74ca

…to dev/joyceerhl/remove-run-above-below

joyceerhl merged commit 2cb3476 into main Jun 3, 2021

joyceerhl deleted the dev/joyceerhl/remove-run-above-below branch June 3, 2021 01:55

joyceerhl added a commit that referenced this pull request Jun 3, 2021

Remove our Run Above/Below commands (#6026)

1ba0077

joyceerhl added a commit that referenced this pull request Jun 3, 2021

Port #6025 to release (#6103)

06f396a

* Remove our Run Above/Below commands (#6026) * Update changelog

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove our Run Above/Below commands #6026

Remove our Run Above/Below commands #6026

joyceerhl commented May 28, 2021 •

edited

Loading

codecov-commenter commented May 28, 2021 •

edited

Loading

joyceerhl commented Jun 1, 2021

IanMatthewHuff commented Jun 1, 2021

rchiodo Jun 1, 2021

rchiodo Jun 1, 2021

joyceerhl commented Jun 1, 2021

		@@ -0,0 +1 @@
		Replace 'Run cells above' and 'Run cell and below' commands and cell toolbar buttons with VS Code's built-in 'Execute Above Cells' and 'Execute Cell And Below' commands and unified run button.

Remove our Run Above/Below commands #6026

Remove our Run Above/Below commands #6026

Conversation

joyceerhl commented May 28, 2021 • edited Loading

codecov-commenter commented May 28, 2021 • edited Loading

Codecov Report

joyceerhl commented Jun 1, 2021

IanMatthewHuff commented Jun 1, 2021

rchiodo Jun 1, 2021

Choose a reason for hiding this comment

rchiodo Jun 1, 2021

Choose a reason for hiding this comment

joyceerhl commented Jun 1, 2021

joyceerhl commented May 28, 2021 •

edited

Loading

codecov-commenter commented May 28, 2021 •

edited

Loading