Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libpq] update to 12.0 #8551

Closed
wants to merge 57 commits into from
Closed

Conversation

Neumann-A
Copy link
Contributor

Original #8487. Testing how far this will get on windows

@Neumann-A Neumann-A changed the title [libpq] update to 12.0 (CI test run) [libpq] update to 12.0 Oct 14, 2019
@vicroms
Copy link
Member

vicroms commented Oct 16, 2019

I must say I'm impressed by the sheer number of perl patches needed for this PR, kudos!

It'll take me some time to review it thoroughly but with just a cursory look everything seems to be OK.

@JackBoosY
Copy link
Contributor

/azp run

@Neumann-A
Copy link
Contributor Author

Neumann-A commented Dec 4, 2019

@JackBoosY @vicroms Can somebody rerun CI for this one. The update is required so that vcpkg can move to OpenSSL 1.1

nevermind just read hat CI is down ;)

@JackBoosY
Copy link
Contributor

/azp run

Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are no modifications to vcpkg_build_make.cmake/vcpkg_common_functions.cmake /ports.cmake , please revert them.

@Neumann-A
Copy link
Contributor Author

@JackBoosY Reverting will be a bit difficult since your "make PR" was merged in here and fixed before it was in master. will try to copy files over from master and remove the diff that way but will wait until the qt PR (#9260) is merged

@Neumann-A
Copy link
Contributor Author

If there are no modifications to vcpkg_build_make.cmake/vcpkg_common_functions.cmake /ports.cmake , please revert them.

@JackBoosY: Done

ports/x264/CONTROL Outdated Show resolved Hide resolved
@cenit
Copy link
Contributor

cenit commented Jan 13, 2020

also, another note: patches are full of "non-changes" with only the # This must be updated comment appended. Is it some work left to do or is it possible to clean up those patches?

@Neumann-A
Copy link
Contributor Author

also, another note: patches are full of "non-changes" with only the # This must be updated comment appended. Is it some work left to do or is it possible to clean up those patches?

Some of those changes in the _release.patch are just to keep symmetry with the _debug.patch. Path to GSS libs probably must be changed but the required port is not yet in VCPKG(?). Some of the OpenSSL patches could be removed though but redoing the diff without the original buildtree requires extra time.

@Neumann-A Neumann-A closed this Jan 13, 2020
@Neumann-A Neumann-A deleted the libpq-12.0 branch November 18, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants