[qt5-base] Fix Qt5 linux build and be a bit less flaky in CI #9260

Neumann-A · 2019-12-09T18:39:33Z

No description provided.

closes microsoft#9234 and microsoft#9239

fixes some observed linkage issues

…o fix_qt_linux

Neumann-A · 2019-12-11T18:19:08Z

There was also an issue with linkage of expat. Have to find the port linking to it

Neumann-A · 2019-12-11T18:23:07Z

will add the following fixes described here as soon as i have time:
~~#8912 (comment)~~ (not solveable requires information about dependent libraries features within vcpkg)
~~#8912 (comment)~~

JackBoosY · 2019-12-12T02:48:30Z

/azp run

Neumann-A · 2019-12-12T16:10:49Z

So I included every fix I know of in this PR.

ah ok #9299 still needs fixing

janholt · 2019-12-12T18:29:44Z

Seems there are two problems with Qt that worth to note.

On x64-linux Debug and Release installations are not merged.
Qt5CoreConfig.cmake on x64-linux only has

    _populate_Core_target_properties(RELEASE "libQt5Core.a" "" )

while on x64-windows there is

    _populate_Core_target_properties(RELEASE "Qt5Core.dll" "Qt5Core.lib" )

    if (EXISTS
        "${_qt5Core_install_prefix}/debug/bin/Qt5Cored.dll"
      AND EXISTS
        "${_qt5Core_install_prefix}/debug/lib/Qt5Cored.lib" )
        _populate_Core_target_properties(DEBUG "Qt5Cored.dll" "Qt5Cored.lib" )
    endif()

And the major one: there is no "direct" way to link static Qt from cmake (no targets for plugins and additional libraries(Qt5ThemeSupport), dependencies(external, internal) not declared). So x64-linux does not work out-of-the-box.
Here is the work on this topic: https://bugreports.qt.io/browse/QTBUG-38913

Neumann-A · 2019-12-12T19:37:50Z

I'll adress #9296 and #9299 next

Neumann-A · 2019-12-12T19:51:09Z

next issue: _populate_Core_plugin_properties only populates release properties

Neumann-A · 2019-12-12T20:20:55Z

hmm seems like fixcmake.py is not 100% doing what it should be

    dllpattern = re.compile("_install_prefix}/bin/Qt5.*d+(.dll|.so)")
    libpattern = re.compile("_install_prefix}/lib/Qt5.*d+(.lib|.a)")
    exepattern = re.compile("_install_prefix}/bin/[a-z]+(.exe|)")
    toolexepattern = re.compile("_install_prefix}/tools/qt5/bin/[a-z]+(.exe|)")
    tooldllpattern = re.compile("_install_prefix}/tools/qt5/bin/Qt5.*d+(.dll|.so)")

Neumann-A · 2019-12-12T22:51:37Z

@janholt: Your issue should be solved now

JackBoosY · 2019-12-13T03:10:16Z

If you have completed this fix, please let me know.

Thanks.

Neumann-A · 2019-12-15T22:41:47Z

Also VTK should build on linux. The error is:

CMake Error at Rendering/OpenGL2/CMakeLists.txt:154 (message):
  X11_Xt_LIB could not be found.  Required for VTK X lib.

so the CI machine is missing some required system library

JackBoosY · 2019-12-16T04:57:59Z

Also VTK should build on linux. The error is:
CMake Error at Rendering/OpenGL2/CMakeLists.txt:154 (message):
  X11_Xt_LIB could not be found.  Required for VTK X lib.
so the CI machine is missing some required system library

Confirmed.

scripts/ci.baseline.txt

zweistein-frm2 · 2019-12-16T09:29:52Z

Hello,
I lost track on wether the qt5 linux (or WSL) build is working now? Which branch should I use? Please could you give a simple link as I am not so literate in advanced git. Thank you

Neumann-A · 2019-12-16T09:58:39Z

@zweistein-frm2: If you cannot wait until this is merged into master:

git clone https://github.com/microsoft/vcpkg.git
git remote add Neumann-A https://github.com/Neumann-A/vcpkg.git
git fetch Neumann-A
git merge Neumann-A/fix_qt_linux

zweistein-frm2 · 2019-12-17T06:36:09Z

OK, almost there, takes 6-12 h to compile on linux and goes through
But when I want to install something else (vcpkg install boost for example) then I get
Error: database corrupted. Package qt5:x64-linux is installed but dependency qt5-purchasing:x64-linux is not. Seems that vcpkg installation is busted!

zweistein-frm2 · 2019-12-17T06:42:13Z

Seems that the database corruptions occurred only on a Windows and WSL install. On a real Ubuntu 18.04 there are no problems

zweistein-frm2 · 2019-12-17T06:46:42Z

Maybe related: The windows vcpkg and the WSL vcpkg directories point to the same folder. Should be fine? as the triplets are in seperate folders

Neumann-A · 2019-12-17T07:37:35Z

Error: database corrupted. Package qt5:x64-linux is installed but dependency qt5-purchasing:x64-linux is not. Seems that vcpkg installation is busted!

Yep the reason is:

Maybe related: The windows vcpkg and the WSL vcpkg directories point to the same folder. Should be fine?

No its not fine. vcpkg is not designed to be run in parallel into the same installed folder. This typically corrupts the database located in the folder installed/vcpkg

ras0219-msft · 2019-12-21T01:17:20Z

ports/qt5-base/vcpkg-cmake-wrapper.cmake

-        find_library(${_lib}_LIBRARY_RELEASE NAMES ${_lib} PATH_SUFFIXES plugins/platforms)
-        set_property(TARGET ${_target} APPEND PROPERTY INTERFACE_LINK_LIBRARIES
-        \$<\$<NOT:\$<CONFIG:DEBUG>>:${${_lib}_LIBRARY_RELEASE}>\$<\$<CONFIG:DEBUG>:${${_lib}_LIBRARY_DEBUG}>)
+        #The fact that we are within this file means we are using the VCPKG toolchain. Has such we only need to search in VCPKG paths!


ras0219-msft · 2019-12-21T01:22:27Z

No its not fine. vcpkg is not designed to be run in parallel into the same installed folder.

You're 100% correct, but just to be very verbose about it:

Running multiple vcpkg processes operating on the same instance at the same time is not allowed.
Sharing one instance between Windows and WSL is allowed (as long as you don't modify it from both at the same time).

So it's ok to open a windows prompt, run vcpkg install xyz, wait for it to finish, then open wsl and run the same command. It's not ok to launch CMD and WSL prompts and run vcpkg install xyz in both to see which finishes first.

ras0219-msft · 2019-12-21T01:24:30Z

/azp run

JackBoosY · 2020-01-03T02:51:54Z

/azp run

Neumann-A and others added 5 commits December 9, 2019 19:31

Fix static qt5 builds and ignore system qmake

43b799d

closes microsoft#9234 and microsoft#9239

fix angle conflict and icu dependency

7c02fd9

add egl-registry as a dependency

9aae04e

remove space

364abb2

adding spaces resolved the problem

b19bd48

PhoebeHui requested a review from JackBoosY December 10, 2019 02:54

Neumann-A and others added 4 commits December 10, 2019 09:58

move files only if they exist

b0cda9a

Update the Wrapper to use the Postgres target

86fc540

fixes some observed linkage issues

update baseline

a940b82

Merge branch 'fix_qt_linux' of https://github.com/Neumann-A/vcpkg int…

58f569f

…o fix_qt_linux

Neumann-A mentioned this pull request Dec 10, 2019

[angle]Fix windows build error: cannot find definition far. #7923

Merged

Neumann-A added 2 commits December 12, 2019 16:57

add fontconfig on linux so CI is less flaky in a full rebuild

6f4696b

fix linkage dependent qt5-imageformats libs

f526cc0

janholt mentioned this pull request Dec 12, 2019

Cannot build Qt project on Linux, but it does on windows #9296

Closed

Neumann-A added 2 commits December 12, 2019 21:15

Fix Wrapper for Linux and add other platform libs to Qt5::Core

d32f561

fix plugin properties in cmake files

88f18d1

fix cmake files.

8fce303

Neumann-A added 3 commits December 12, 2019 23:58

fix missing plugin qminimal deployment into tools dir

0a9d838

change wrapper slightly

f57228d

UNIX also means APPLE so it needs to be excluded

7b3b5ca

Neumann-A added 2 commits December 15, 2019 23:32

update baseline. VTK builds in local WSL so it should work in CI

ef5b16a

update VTK control to force rebuild

832ac09

JackBoosY suggested changes Dec 16, 2019

View reviewed changes

scripts/ci.baseline.txt Outdated Show resolved Hide resolved

This was referenced Dec 16, 2019

[libpq] update to 12.0 #8551

Closed

Building package qt5-base:x64-linux failed with: BUILD_FAILED #4804

Closed

remove qt5-tools=pass from baseline

59fc67e

JackBoosY approved these changes Dec 16, 2019

View reviewed changes

JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Dec 16, 2019

JackBoosY requested a review from PhoebeHui December 17, 2019 02:09

PhoebeHui assigned JackBoosY Dec 17, 2019

dan-shaw self-assigned this Dec 19, 2019

dan-shaw added the needs-further-review label Dec 19, 2019

ras0219-msft reviewed Dec 21, 2019

View reviewed changes

Merge branch 'master' into fix_qt_linux

bbcb6e0

remove qcustomplot:x64-linux=fail from baseline

fbe6c26

dan-shaw merged commit f8165f7 into microsoft:master Jan 6, 2020

Neumann-A deleted the fix_qt_linux branch January 31, 2020 13:01

Be-ing mentioned this pull request Sep 11, 2021

Use 2.4 vcpkg branch for MacOS and Windows mixxxdj/mixxx#4225

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[qt5-base] Fix Qt5 linux build and be a bit less flaky in CI #9260

[qt5-base] Fix Qt5 linux build and be a bit less flaky in CI #9260

Neumann-A commented Dec 9, 2019

Neumann-A commented Dec 11, 2019

Neumann-A commented Dec 11, 2019 •

edited

Loading

JackBoosY commented Dec 12, 2019

Neumann-A commented Dec 12, 2019 •

edited

Loading

janholt commented Dec 12, 2019

Neumann-A commented Dec 12, 2019

Neumann-A commented Dec 12, 2019

Neumann-A commented Dec 12, 2019

Neumann-A commented Dec 12, 2019

JackBoosY commented Dec 13, 2019

Neumann-A commented Dec 15, 2019

JackBoosY commented Dec 16, 2019

zweistein-frm2 commented Dec 16, 2019

Neumann-A commented Dec 16, 2019

zweistein-frm2 commented Dec 17, 2019

zweistein-frm2 commented Dec 17, 2019

zweistein-frm2 commented Dec 17, 2019

Neumann-A commented Dec 17, 2019

ras0219-msft Dec 21, 2019

ras0219-msft commented Dec 21, 2019

ras0219-msft commented Dec 21, 2019

JackBoosY commented Jan 3, 2020

[qt5-base] Fix Qt5 linux build and be a bit less flaky in CI #9260

[qt5-base] Fix Qt5 linux build and be a bit less flaky in CI #9260

Conversation

Neumann-A commented Dec 9, 2019

Neumann-A commented Dec 11, 2019

Neumann-A commented Dec 11, 2019 • edited Loading

JackBoosY commented Dec 12, 2019

Neumann-A commented Dec 12, 2019 • edited Loading

janholt commented Dec 12, 2019

Neumann-A commented Dec 12, 2019

Neumann-A commented Dec 12, 2019

Neumann-A commented Dec 12, 2019

Neumann-A commented Dec 12, 2019

JackBoosY commented Dec 13, 2019

Neumann-A commented Dec 15, 2019

JackBoosY commented Dec 16, 2019

zweistein-frm2 commented Dec 16, 2019

Neumann-A commented Dec 16, 2019

zweistein-frm2 commented Dec 17, 2019

zweistein-frm2 commented Dec 17, 2019

zweistein-frm2 commented Dec 17, 2019

Neumann-A commented Dec 17, 2019

ras0219-msft Dec 21, 2019

Choose a reason for hiding this comment

ras0219-msft commented Dec 21, 2019

ras0219-msft commented Dec 21, 2019

JackBoosY commented Jan 3, 2020

Neumann-A commented Dec 11, 2019 •

edited

Loading

Neumann-A commented Dec 12, 2019 •

edited

Loading