[libpq] update to 12.0 and use vcpkg_configure_make

[TheScarfix]

will close #8462

[cenit]

This means that you can also remove the custom CMakeLists.txt?

[TheScarfix]

yes I hope to as soon as it works

[cenit]

I noted it only to not forget it. Since I just finished a tedious cleanup of many old and deprecated patches, I like to keep the repo clean now :)

[JackBoosY]

I think it should be set as a macro,

[Neumann-A]

please fix the title. there is no

change to vcpkg_configure_make

as far as I can see from the changes.

[cenit]

it was vcpkg_configure_cmake, now it is vcpkg_configure_make

[Neumann-A]

I read it as a change to the function/script vcpkg_configure_make.
Maybe it should be "and use vcpkg_configure_make" or "remove custom CMake build" or "use native build scripts".

[Neumann-A]

So I hacked the C99 check away (missing register keyword and the C equivalent to constexpr?) and fixed some Compiler/Linker flags but got stuck with the following error:

conftest.c
configure:8526: checking for non-GNU ld
configure:8559: result: no
configure:8562: error: no acceptable ld found in $PATH

If you then force in the portfile:
set(ENV{LD} "link.exe")
you get:

warnings:

cl : Command line warning D9035 : option 'o' has been deprecated and will be removed in a future release
cl : Command line warning D9002 : ignoring unknown option '-g'
cl : Command line warning D9002 : ignoring unknown option '--allow-multiple-definition'
cl : Command line warning D9002 : ignoring unknown option '--disable-auto-import'
cl : Command line warning D9002 : ignoring unknown option '-lz'
cl : Command line warning D9002 : ignoring unknown option '-lm'

configure:11813: result: no
configure:11823: error: zlib library not found
If you have zlib already installed, see config.log for details on the
failure.  It is possible the compiler isn't looking in the proper directory.
Use --without-zlib to disable zlib support.

I mean yeah you could patch the whole configure script on windows but it is probably easier to roll our own CMakeLists.txt file for libpq on Windows

Also from the config log some questionable checks:
checking for C/C++ restrict keyword... no
which is a double check due to the C99 check ....
checking for main in -lm... yes
because cl is just ignore -lm.....

[TheScarfix]

I'll try the MSBuild script later https://www.postgresql.org/docs/12/install-windows.html

[Neumann-A]

yeah that is probably the way to go. the files are in src\tools\msvc if you are looking for the scripts

[Neumann-A]

after reviewing the configure log you probably also need to explicitly pass the path of external dependencies like zlib to the configure script on linux to get consistent builds or the script will check if it can link -lz and if zlib is installed system wide (not the vcpkg version) it will catch that dependency and result in an inconsistent build.

[Neumann-A]

Furthermore if all configure options of libpq like zlib and libxml are features of libpq I need #8269 solved to make Qt work correctly in static builds.

[Neumann-A]

So got x86-windows to build without any features using the perl scripts.
https://github.com/Neumann-A/vcpkg/tree/libpq-12.0
you currently have to rename win_flex and win_bison to only bison and flex

[Neumann-A]

@TheScarfix: So I made the windows build work. I assume you want to have PR #8540 merged before working on the linux side?

[TheScarfix]

I currently don't have the time to work on this, moving tomorrow. Hope I can look at it this weekend.