[onnxruntime] Refactor install process #23768

JackBoosY · 2022-03-25T09:08:03Z

The purpose of this PR is to change the direct installation of precompiled binaries to generate binaries via the cmake build system:

Refactor onnxruntime-gpu.
Rename port onnxruntime-cpu to onnxruntime and add feature gpu.
Set onnxruntime-gpu as a empty port and depends on onnxruntime[gpu].

Fixes #20548.

ports/onnxruntime-gpu/fix-build-issues.patch

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout a76eb002a71b6cf7bad343f5e3376dfe6bb83c5c -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 830818f..967d62e 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5005,8 +5005,8 @@
       "port-version": 0
     },
     "onnxruntime-gpu": {
-      "baseline": "1.5.1",
-      "port-version": 1
+      "baseline": "1.10.0",
+      "port-version": 0
     },
     "oof": {
       "baseline": "2021-11-23",
diff --git a/versions/o-/onnxruntime-gpu.json b/versions/o-/onnxruntime-gpu.json
index 1fe9baf..9c7641e 100644
--- a/versions/o-/onnxruntime-gpu.json
+++ b/versions/o-/onnxruntime-gpu.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "faee025bc77f3bae54d9305bc6361e622df4c719",
+      "version": "1.10.0",
+      "port-version": 0
+    },
     {
       "git-tree": "9741bef63d2b0c74277568da67ab7aa1ab50c51b",
       "version": "1.5.1",

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/onnxruntime-gpu/vcpkg.json

Valid values for the license field can be found in the documentation

JackBoosY · 2022-03-25T09:25:52Z

@snnn
There still remains some build errors:

...
 Assembling: F:\vcpkg\buildtrees\onnxruntime-gpu\src\53c7b640c1-c8ff6da815\onnxruntime\core\mlas\lib\amd64\QgemmU8S8KernelAvx2.asm
F:\vcpkg\buildtrees\onnxruntime-gpu\src\53c7b640c1-c8ff6da815\onnxruntime\core\mlas\lib\amd64\QgemmU8S8KernelAvx2.asm(110) : error A2119:language type must be specified
 NESTED_ENTRY(28): Macro Called From
  F:\vcpkg\buildtrees\onnxruntime-gpu\src\53c7b640c1-c8ff6da815\onnxruntime\core\mlas\lib\amd64\QgemmU8S8KernelAvx2.asm(110): Main Line Code
F:\vcpkg\buildtrees\onnxruntime-gpu\src\53c7b640c1-c8ff6da815\onnxruntime\core\mlas\lib\amd64\QgemmU8S8KernelAvx2.asm(112) : error A2008:syntax error : .
 rex_push_reg(4): Macro Called From
  F:\vcpkg\buildtrees\onnxruntime-gpu\src\53c7b640c1-c8ff6da815\onnxruntime\core\mlas\lib\amd64\QgemmU8S8KernelAvx2.asm(112): Main Line Code
F:\vcpkg\buildtrees\onnxruntime-gpu\src\53c7b640c1-c8ff6da815\onnxruntime\core\mlas\lib\amd64\QgemmU8S8KernelAvx2.asm(113) : error A2008:syntax error : .
 push_reg(3): Macro Called From
  F:\vcpkg\buildtrees\onnxruntime-gpu\src\53c7b640c1-c8ff6da815\onnxruntime\core\mlas\lib\amd64\QgemmU8S8KernelAvx2.asm(113): Main Line Code
F:\vcpkg\buildtrees\onnxruntime-gpu\src\53c7b640c1-c8ff6da815\onnxruntime\core\mlas\lib\amd64\QgemmU8S8KernelAvx2.asm(114) : error A2008:syntax error : .
...

Can you please take a look?

Thanks.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout a76eb002a71b6cf7bad343f5e3376dfe6bb83c5c -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 830818f..967d62e 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5005,8 +5005,8 @@
       "port-version": 0
     },
     "onnxruntime-gpu": {
-      "baseline": "1.5.1",
-      "port-version": 1
+      "baseline": "1.10.0",
+      "port-version": 0
     },
     "oof": {
       "baseline": "2021-11-23",
diff --git a/versions/o-/onnxruntime-gpu.json b/versions/o-/onnxruntime-gpu.json
index 1fe9baf..a3b3d33 100644
--- a/versions/o-/onnxruntime-gpu.json
+++ b/versions/o-/onnxruntime-gpu.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "a8f1f30171b4d44a83e0efc2821411a6ecbf86ce",
+      "version": "1.10.0",
+      "port-version": 0
+    },
     {
       "git-tree": "9741bef63d2b0c74277568da67ab7aa1ab50c51b",
       "version": "1.5.1",

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/onnxruntime-gpu/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout a76eb002a71b6cf7bad343f5e3376dfe6bb83c5c -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 71358c2..eabd793 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5005,8 +5005,8 @@
       "port-version": 0
     },
     "onnxruntime-gpu": {
-      "baseline": "1.5.1",
-      "port-version": 1
+      "baseline": "1.10.0",
+      "port-version": 0
     },
     "oof": {
       "baseline": "2021-11-23",
diff --git a/versions/o-/onnxruntime-gpu.json b/versions/o-/onnxruntime-gpu.json
index 1fe9baf..f63f063 100644
--- a/versions/o-/onnxruntime-gpu.json
+++ b/versions/o-/onnxruntime-gpu.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "8c4232954897e70f090c4131096a09e49e93703d",
+      "version": "1.10.0",
+      "port-version": 0
+    },
     {
       "git-tree": "9741bef63d2b0c74277568da67ab7aa1ab50c51b",
       "version": "1.5.1",

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/onnxruntime-gpu/vcpkg.json

Valid values for the license field can be found in the documentation

ports/onnxruntime-gpu/vcpkg.json

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/onnxruntime-gpu/vcpkg.json b/ports/onnxruntime-gpu/vcpkg.json
index bfb2ad5..d1e4ae6 100644
--- a/ports/onnxruntime-gpu/vcpkg.json
+++ b/ports/onnxruntime-gpu/vcpkg.json
@@ -15,10 +15,10 @@
     "protobuf",
     "re2",
     "safeint",
-    "wil",
     {
       "name": "vcpkg-cmake",
       "host": true
-    }
+    },
+    "wil"
   ]
 }

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout a76eb002a71b6cf7bad343f5e3376dfe6bb83c5c -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 71358c2..eabd793 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5005,8 +5005,8 @@
       "port-version": 0
     },
     "onnxruntime-gpu": {
-      "baseline": "1.5.1",
-      "port-version": 1
+      "baseline": "1.10.0",
+      "port-version": 0
     },
     "oof": {
       "baseline": "2021-11-23",
diff --git a/versions/o-/onnxruntime-gpu.json b/versions/o-/onnxruntime-gpu.json
index 1fe9baf..f9197d1 100644
--- a/versions/o-/onnxruntime-gpu.json
+++ b/versions/o-/onnxruntime-gpu.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "2839acfe6ee1afcd94eef0b0a04bb3b5635fefe1",
+      "version": "1.10.0",
+      "port-version": 0
+    },
     {
       "git-tree": "9741bef63d2b0c74277568da67ab7aa1ab50c51b",
       "version": "1.5.1",

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/onnxruntime-gpu/vcpkg.json

Valid values for the license field can be found in the documentation

ports/onnxruntime-gpu/vcpkg.json

JackBoosY · 2022-03-28T07:36:28Z

Depends on #23811.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/onnxruntime-gpu/vcpkg.json b/ports/onnxruntime-gpu/vcpkg.json
index 8e9bb62..6bce1d6 100644
--- a/ports/onnxruntime-gpu/vcpkg.json
+++ b/ports/onnxruntime-gpu/vcpkg.json
@@ -19,10 +19,10 @@
     "protobuf",
     "re2",
     "safeint",
-    "wil",
     {
       "name": "vcpkg-cmake",
       "host": true
-    }
+    },
+    "wil"
   ]
 }

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout a76eb002a71b6cf7bad343f5e3376dfe6bb83c5c -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 71358c2..eabd793 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5005,8 +5005,8 @@
       "port-version": 0
     },
     "onnxruntime-gpu": {
-      "baseline": "1.5.1",
-      "port-version": 1
+      "baseline": "1.10.0",
+      "port-version": 0
     },
     "oof": {
       "baseline": "2021-11-23",
diff --git a/versions/o-/onnxruntime-gpu.json b/versions/o-/onnxruntime-gpu.json
index 1fe9baf..1b98c05 100644
--- a/versions/o-/onnxruntime-gpu.json
+++ b/versions/o-/onnxruntime-gpu.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "00e2252146848f97d5e8b2b84d77225b4edc2c2c",
+      "version": "1.10.0",
+      "port-version": 0
+    },
     {
       "git-tree": "9741bef63d2b0c74277568da67ab7aa1ab50c51b",
       "version": "1.5.1",

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/onnxruntime-gpu/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/onnxruntime-gpu/vcpkg.json b/ports/onnxruntime-gpu/vcpkg.json
index 8e9bb62..6bce1d6 100644
--- a/ports/onnxruntime-gpu/vcpkg.json
+++ b/ports/onnxruntime-gpu/vcpkg.json
@@ -19,10 +19,10 @@
     "protobuf",
     "re2",
     "safeint",
-    "wil",
     {
       "name": "vcpkg-cmake",
       "host": true
-    }
+    },
+    "wil"
   ]
 }

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout a76eb002a71b6cf7bad343f5e3376dfe6bb83c5c -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 71358c2..eabd793 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5005,8 +5005,8 @@
       "port-version": 0
     },
     "onnxruntime-gpu": {
-      "baseline": "1.5.1",
-      "port-version": 1
+      "baseline": "1.10.0",
+      "port-version": 0
     },
     "oof": {
       "baseline": "2021-11-23",
diff --git a/versions/o-/onnxruntime-gpu.json b/versions/o-/onnxruntime-gpu.json
index 1fe9baf..a36d46b 100644
--- a/versions/o-/onnxruntime-gpu.json
+++ b/versions/o-/onnxruntime-gpu.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "dc4c461689a81d7dfaf5feeab01fdd7c9829026d",
+      "version": "1.10.0",
+      "port-version": 0
+    },
     {
       "git-tree": "9741bef63d2b0c74277568da67ab7aa1ab50c51b",
       "version": "1.5.1",

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/onnxruntime-gpu/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/onnxruntime-gpu/vcpkg.json b/ports/onnxruntime-gpu/vcpkg.json
index 8e9bb62..6bce1d6 100644
--- a/ports/onnxruntime-gpu/vcpkg.json
+++ b/ports/onnxruntime-gpu/vcpkg.json
@@ -19,10 +19,10 @@
     "protobuf",
     "re2",
     "safeint",
-    "wil",
     {
       "name": "vcpkg-cmake",
       "host": true
-    }
+    },
+    "wil"
   ]
 }

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout a76eb002a71b6cf7bad343f5e3376dfe6bb83c5c -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 71358c2..eabd793 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5005,8 +5005,8 @@
       "port-version": 0
     },
     "onnxruntime-gpu": {
-      "baseline": "1.5.1",
-      "port-version": 1
+      "baseline": "1.10.0",
+      "port-version": 0
     },
     "oof": {
       "baseline": "2021-11-23",
diff --git a/versions/o-/onnxruntime-gpu.json b/versions/o-/onnxruntime-gpu.json
index 1fe9baf..3f02e28 100644
--- a/versions/o-/onnxruntime-gpu.json
+++ b/versions/o-/onnxruntime-gpu.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "1405a1116eb6b44b3b6350832b085bd750233c79",
+      "version": "1.10.0",
+      "port-version": 0
+    },
     {
       "git-tree": "9741bef63d2b0c74277568da67ab7aa1ab50c51b",
       "version": "1.5.1",

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/onnxruntime-gpu/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/onnxruntime-gpu/vcpkg.json b/ports/onnxruntime-gpu/vcpkg.json
index 8e9bb62..6bce1d6 100644
--- a/ports/onnxruntime-gpu/vcpkg.json
+++ b/ports/onnxruntime-gpu/vcpkg.json
@@ -19,10 +19,10 @@
     "protobuf",
     "re2",
     "safeint",
-    "wil",
     {
       "name": "vcpkg-cmake",
       "host": true
-    }
+    },
+    "wil"
   ]
 }

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout a76eb002a71b6cf7bad343f5e3376dfe6bb83c5c -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 71358c2..eabd793 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5005,8 +5005,8 @@
       "port-version": 0
     },
     "onnxruntime-gpu": {
-      "baseline": "1.5.1",
-      "port-version": 1
+      "baseline": "1.10.0",
+      "port-version": 0
     },
     "oof": {
       "baseline": "2021-11-23",
diff --git a/versions/o-/onnxruntime-gpu.json b/versions/o-/onnxruntime-gpu.json
index 1fe9baf..5ebfa50 100644
--- a/versions/o-/onnxruntime-gpu.json
+++ b/versions/o-/onnxruntime-gpu.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "4185126f99ca2098f10764a890aa902f9850d449",
+      "version": "1.10.0",
+      "port-version": 0
+    },
     {
       "git-tree": "9741bef63d2b0c74277568da67ab7aa1ab50c51b",
       "version": "1.5.1",

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/onnxruntime-gpu/vcpkg.json

Valid values for the license field can be found in the documentation

…jack/20548

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/onnxruntime-gpu/vcpkg.json b/ports/onnxruntime-gpu/vcpkg.json
index 8e9bb62..6bce1d6 100644
--- a/ports/onnxruntime-gpu/vcpkg.json
+++ b/ports/onnxruntime-gpu/vcpkg.json
@@ -19,10 +19,10 @@
     "protobuf",
     "re2",
     "safeint",
-    "wil",
     {
       "name": "vcpkg-cmake",
       "host": true
-    }
+    },
+    "wil"
   ]
 }

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5f62686b96cecc91a5d02ea188857a24efd3ef4f -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 316e85c..f9296b2 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5005,8 +5005,8 @@
       "port-version": 0
     },
     "onnxruntime-gpu": {
-      "baseline": "1.5.1",
-      "port-version": 1
+      "baseline": "1.10.0",
+      "port-version": 0
     },
     "oof": {
       "baseline": "2021-11-23",
diff --git a/versions/o-/onnxruntime-gpu.json b/versions/o-/onnxruntime-gpu.json
index 1fe9baf..5ebfa50 100644
--- a/versions/o-/onnxruntime-gpu.json
+++ b/versions/o-/onnxruntime-gpu.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "4185126f99ca2098f10764a890aa902f9850d449",
+      "version": "1.10.0",
+      "port-version": 0
+    },
     {
       "git-tree": "9741bef63d2b0c74277568da67ab7aa1ab50c51b",
       "version": "1.5.1",

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/onnxruntime-gpu/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/onnxruntime-gpu/vcpkg.json b/ports/onnxruntime-gpu/vcpkg.json
index 8e9bb62..6bce1d6 100644
--- a/ports/onnxruntime-gpu/vcpkg.json
+++ b/ports/onnxruntime-gpu/vcpkg.json
@@ -19,10 +19,10 @@
     "protobuf",
     "re2",
     "safeint",
-    "wil",
     {
       "name": "vcpkg-cmake",
       "host": true
-    }
+    },
+    "wil"
   ]
 }

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5f62686b96cecc91a5d02ea188857a24efd3ef4f -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index a63c42f..c3ecd68 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5005,8 +5005,8 @@
       "port-version": 0
     },
     "onnxruntime-gpu": {
-      "baseline": "1.5.1",
-      "port-version": 1
+      "baseline": "1.10.0",
+      "port-version": 0
     },
     "oof": {
       "baseline": "2021-11-23",
diff --git a/versions/o-/onnxruntime-gpu.json b/versions/o-/onnxruntime-gpu.json
index 1fe9baf..434e0f4 100644
--- a/versions/o-/onnxruntime-gpu.json
+++ b/versions/o-/onnxruntime-gpu.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "1a50c883e0cb4a121331129b4c078326e181ae40",
+      "version": "1.10.0",
+      "port-version": 0
+    },
     {
       "git-tree": "9741bef63d2b0c74277568da67ab7aa1ab50c51b",
       "version": "1.5.1",

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/onnxruntime-gpu/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/onnxruntime-gpu/vcpkg.json

Valid values for the license field can be found in the documentation

JackBoosY · 2022-04-06T07:42:40Z

The regression is a nvidia cub issue: https://developer.nvidia.com/nvidia_bug/3597169 and was fixed by cub 1.16.0: NVIDIA/cub#423.

Waiting for the next cuda release.

JackBoosY · 2022-04-06T09:34:59Z

Requires #24000.

JackBoosY · 2022-04-07T06:47:15Z

ports/onnxruntime/fix-build-issues.patch

+-          LIBRARY  DESTINATION ${CMAKE_INSTALL_LIBDIR}
+          LIBRARY  DESTINATION ${CMAKE_INSTALL_BINDIR}


Upstream PR: microsoft/onnxruntime#11136

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for onnxruntime but no changes to version or port version.
-- Version: 1.10.0
-- Old SHA: 997e14c6182e9be576208cb664d65ce15fc25545
-- New SHA: 97dbbd1a31ff884c4ecfe95f8849303dfaab5f82
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/onnxruntime-gpu/vcpkg.json

Valid values for the license field can be found in the documentation

…rnal compiler error

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for onnxruntime but no changes to version or port version.
-- Version: 1.10.0
-- Old SHA: 997e14c6182e9be576208cb664d65ce15fc25545
-- New SHA: 97dbbd1a31ff884c4ecfe95f8849303dfaab5f82
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/onnxruntime-gpu/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for onnxruntime but no changes to version or port version.
-- Version: 1.10.0
-- Old SHA: 997e14c6182e9be576208cb664d65ce15fc25545
-- New SHA: 97dbbd1a31ff884c4ecfe95f8849303dfaab5f82
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/onnxruntime-gpu/vcpkg.json

Valid values for the license field can be found in the documentation

BillyONeal · 2022-04-08T18:29:38Z

ports/onnxruntime/portfile.cmake

+        -Donnxruntime_BUILD_UNIT_TESTS=OFF
+        -Donnxruntime_BUILD_CSHARP=OFF
+        -Donnxruntime_BUILD_OBJC=OFF
+        -Donnxruntime_USE_PREINSTALLED_EIGEN=ON


Isn't this vendored stuff? (Maybe it's entirely encapsulated in their DLL though...)

BillyONeal · 2022-04-08T18:30:05Z

ports/onnxruntime/portfile.cmake

+        -Donnxruntime_USE_AVX=OFF
+        -Donnxruntime_USE_AVX2=OFF
+        -Donnxruntime_USE_AVX512=OFF


Are we sure about these? It probably makes any cpu use of this thing useless.

When onnxruntime_USE_AVX is ON, the target CPU must have AVX, otherwise the generated binaries will crash. The build machine might not be the one which will run the code, so it doesn't know if the target CPU has AVX or not.

However, even when all these options are off, our math lib, mlas, still can use AVX/AVX2/AVX512 instructions. It dynamically detect the target CPU's capability. Eigen doesn't do it. ONNX Runtime uses Eigen too. So these options are mainly for the kernels that do not use mlas.

Sounds good. That probably deserves a comment.

BillyONeal · 2022-04-08T18:30:56Z

ports/onnxruntime/portfile.cmake

+        -Donnxruntime_USE_VALGRIND=OFF
+        -Donnxruntime_RUN_MODELTEST_IN_DEBUG_MODE=OFF
+        -Donnxruntime_FUZZ_TEST=OFF
+        -Donnxruntime_USE_NCCL=OFF


NCCL is part of CUDA. Should this one be controlled by the GPU feature?

BillyONeal · 2022-04-08T18:31:37Z

ports/onnxruntime/portfile.cmake

+        -Donnxruntime_USE_TENSORRT=OFF
+        -Donnxruntime_ENABLE_LTO=ON
+        -Donnxruntime_DEBUG_NODE_INPUTS_OUTPUTS=OFF
+        -Donnxruntime_USE_ROCM=OFF # AMD GPU SUPPORT


This suggests that the name of the feature should be "cuda" rather than "gpu"? (If the AMD support ever gets fixed that lets us introduce a feature in the future "gpu" that depends on both cuda and amdgpu or similar)

BillyONeal · 2022-04-08T18:32:15Z

ports/onnxruntime/portfile.cmake

+        -Donnxruntime_ENABLE_CUDA_LINE_NUMBER_INFO=OFF
+        -Donnxruntime_GENERATE_TEST_REPORTS=OFF
+        -Donnxruntime_ENABLE_STATIC_ANALYSIS=OFF
+        -Donnxruntime_ENABLE_PYTHON=OFF


Do you need to still pass a python binary given that you set ENABLE_PYTHON to off?

When onnxruntime_BUILD_SHARED_LIB is ON, we need a python interpreter to do codegen. See: https://github.com/microsoft/onnxruntime/blob/master/cmake/onnxruntime.cmake#L49 The script generates a DLL def file.

BillyONeal · 2022-04-08T18:33:04Z

ports/onnxruntime/portfile.cmake

+        -Donnxruntime_CROSS_COMPILING=${CROSS_BUILD}
+        -DCMAKE_INSTALL_INCLUDEDIR=include
+        "-DPython_EXECUTABLE=${PYTHON3}"
+        -Donnxruntime_RUN_ONNX_TESTS=OFF


How do these options compare to the options used to build the DLLs that we used to download/deploy? (Will customers see one of these things that are off and consider it a regression?)

BillyONeal · 2022-04-08T18:34:34Z

ports/onnxruntime/vcpkg.json

+        "cuda",
+        "cudnn"


These mean the port is expected to call vcpkg_find_cuda but I don't see such a call here?

JackBoosY · 2022-04-14T02:49:15Z

I will continue this PR when the next CUDA release published.

Dr-Electron · 2022-05-18T07:51:24Z

I will continue this PR when the next CUDA release published.

Hi, I guess you meant the 11.7 release? Does that mean you will soon continue on this, now that 11.7 got released? Would love to use this package. Not sure if I can help somehow (maybe by testing or something)

JackBoosY · 2022-05-18T09:03:10Z

@Dr-Electron Yes, the current CUDA version has a critical bug that stop onnxruntime build.

BillyONeal · 2022-05-18T18:58:46Z

To clarify: Is the problem that our VMs have CUDA 11.6 rather than 11.7, or that it isn't fixed in 11.7 yet either?

JackBoosY · 2022-05-19T02:25:48Z

cuda_11.6.2_511.65_windows has the bug, but I found CUDA already published cuda_11.7.0_516.01_windows.
I will look at this later.

JackBoosY · 2022-05-19T02:30:17Z

The bug preventing this is that Cub 1.5 has a bug affecting windows macros in Windows.h.
Upstream PR NVIDIA/cub#423 fixed this issue.

JackBoosY · 2022-05-19T05:51:28Z

No, CUDA 11.7.0 doesn't contain the bug fix.

JackBoosY · 2022-05-19T06:47:16Z

Note to me: upstream bug: https://developer.nvidia.com/nvidia_bug/3597169.

BillyONeal · 2022-05-19T07:18:22Z

Thanks for clarifying!

mattiasbax · 2022-05-20T13:40:31Z

What would be my options to wait for CTK 12.x for the fix when it comes to building the onnxruntime .dlls?

JackBoosY · 2022-05-23T02:13:16Z

What would be my options to wait for CTK 12.x for the fix when it comes to building the onnxruntime .dlls?

I think this is useless, CUDA still forces the internal cub to be used even though the cub containing the fixed version of vcpkg is declared to be used.

JackBoosY · 2022-07-04T07:28:16Z

cub 1.16.0 is still TBD: https://github.com/NVIDIA/cub/blob/main/README.md#releases

ankurvdev · 2022-10-10T22:58:04Z

Not sure why this was closed.

If CUDA is an issue. Could we do it two steps
disable CUDA and build onnxruntime with CPU only (without CUDA)
and
add CUDA later when we fix the CUDA related issues.

JackBoosY · 2022-10-13T04:15:17Z

If CUDA is an issue. Could we do it two steps disable CUDA and build onnxruntime with CPU only (without CUDA) and add CUDA later when we fix the CUDA related issues.

We should always ensure that already supported features are always guaranteed to be available.

[onnxruntime] Re-factory install process

7105d81

JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Mar 25, 2022

JackBoosY assigned PhoebeHui Mar 25, 2022

Fix more build issues

577cbf6

JackBoosY commented Mar 25, 2022

View reviewed changes

ports/onnxruntime-gpu/fix-build-issues.patch Outdated Show resolved Hide resolved

github-actions bot requested changes Mar 25, 2022

View reviewed changes

Fix find boost-mp11

eb0c196

github-actions bot requested changes Mar 25, 2022

View reviewed changes

Remove part of patch

b53de7a

github-actions bot requested changes Mar 28, 2022

View reviewed changes

JackBoosY commented Mar 28, 2022

View reviewed changes

ports/onnxruntime-gpu/vcpkg.json Outdated Show resolved Hide resolved

Update ports/onnxruntime-gpu/vcpkg.json

4f11954

github-actions bot requested changes Mar 28, 2022

View reviewed changes

JackBoosY commented Mar 28, 2022

View reviewed changes

ports/onnxruntime-gpu/vcpkg.json Outdated Show resolved Hide resolved

Fix nsync

cfc67e9

github-actions bot requested changes Mar 28, 2022

View reviewed changes

Fix headers installation

5f7103c

github-actions bot requested changes Mar 28, 2022

View reviewed changes

Add python3 requirement

8813745

github-actions bot requested changes Mar 28, 2022

View reviewed changes

Re-fix cpuinfo, add dynamic only.

e788235

github-actions bot requested changes Mar 28, 2022

View reviewed changes

Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…

8386283

…jack/20548

github-actions bot requested changes Mar 29, 2022

View reviewed changes

Fix dependency cpuinfo:clog

c418ae5

github-actions bot requested changes Mar 30, 2022

View reviewed changes

Try to fix build on Linux (temporary)

1e18b52

JackBoosY added 2 commits April 5, 2022 20:10

Fix nvcc path

d0ef05c

version

ec9fcd5

github-actions bot approved these changes Apr 6, 2022

View reviewed changes

Fix dependency cudnn, fix onnxruntime_providers_cuda installation path

86c2d18

JackBoosY commented Apr 7, 2022

View reviewed changes

github-actions bot requested changes Apr 7, 2022

View reviewed changes

JackBoosY mentioned this pull request Apr 8, 2022

Exclude CUDNN environment variables in forbidden list microsoft/vcpkg-tool#477

Closed

[angle] Add x64-windows-static=fail to baesline since there is a inte…

447a5c3

…rnal compiler error

github-actions bot requested changes Apr 8, 2022

View reviewed changes

Pushed wrong branch

e5d5432

github-actions bot requested changes Apr 8, 2022

View reviewed changes

BillyONeal requested changes Apr 8, 2022

View reviewed changes

JackBoosY closed this Oct 10, 2022

Dr-Electron mentioned this pull request Mar 17, 2024

[New Port Request] ONNX Runtime #20548

Open

		- LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
		+ LIBRARY DESTINATION ${CMAKE_INSTALL_BINDIR}

[onnxruntime] Refactor install process #23768

[onnxruntime] Refactor install process #23768

Conversation

JackBoosY commented Mar 25, 2022 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

JackBoosY commented Mar 25, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

JackBoosY commented Mar 28, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

JackBoosY commented Apr 6, 2022 • edited Loading

JackBoosY commented Apr 6, 2022 • edited Loading

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JackBoosY commented Apr 14, 2022

Dr-Electron commented May 18, 2022

JackBoosY commented May 18, 2022

BillyONeal commented May 18, 2022

JackBoosY commented May 19, 2022

JackBoosY commented May 19, 2022 • edited Loading

JackBoosY commented May 19, 2022

JackBoosY commented May 19, 2022

BillyONeal commented May 19, 2022

mattiasbax commented May 20, 2022

JackBoosY commented May 23, 2022

JackBoosY commented Jul 4, 2022

ankurvdev commented Oct 10, 2022

JackBoosY commented Oct 13, 2022

JackBoosY commented Mar 25, 2022 •

edited

Loading

JackBoosY commented Apr 6, 2022 •

edited

Loading

JackBoosY commented Apr 6, 2022 •

edited

Loading

JackBoosY commented May 19, 2022 •

edited

Loading