Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Port Request] ONNX Runtime #20548

Open
horenmar opened this issue Oct 6, 2021 · 7 comments · May be fixed by #36850
Open

[New Port Request] ONNX Runtime #20548

horenmar opened this issue Oct 6, 2021 · 7 comments · May be fixed by #36850
Assignees
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@horenmar
Copy link
Contributor

horenmar commented Oct 6, 2021

Library name: ONNX Runtime

Library description: ONNX Runtime is a cross-platform inference and training machine-learning accelerator.

Source repository URL: https://github.com/microsoft/onnxruntime

Project homepage (if different from the source repository):

Anything else that is useful to know when adding (such as optional features the library may have that should be included): There is bunch of different backends and targets, e.g. cuda, CPU, mobiles, and starting the port with all of them is unlikely to be a good idea, so the initial port could provide just the CPU one.

There has been a PR, #14903, which fizzled out, and related issues, #16509, #14257, and #14635, which all ended up being closed for one reason or another, so I am opening this issue to have an open port request for this package.

@PhoebeHui PhoebeHui added category:new-port The issue is requesting a new library to be added; consider making a PR! info:good-first-issue This issue would be a good issue to get one's feet wet in solving. labels Oct 8, 2021
@JackBoosY
Copy link
Contributor

Now we already have a port named onnxruntime-gpu, is this what you need?

@nxt007
Copy link

nxt007 commented Mar 24, 2022

One main issue is that this port doesn't support linux at all.
As @horenmar mentioned, some useful features are not implemented: cuda and CPU.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist and removed category:new-port The issue is requesting a new library to be added; consider making a PR! info:good-first-issue This issue would be a good issue to get one's feet wet in solving. labels Mar 24, 2022
@JackBoosY JackBoosY self-assigned this Mar 24, 2022
@horenmar
Copy link
Contributor Author

Now we already have a port named onnxruntime-gpu, is this what you need?

No. It downloads old released binaries, doesn't support most platforms, aims towards GPU (I need CPU) and so on.

@JackBoosY
Copy link
Contributor

I'm trying to re-factory this port and add cpu port.

@LilyWangLL LilyWangLL assigned LilyWangLL and unassigned JackBoosY Dec 6, 2022
snnn pushed a commit to microsoft/onnxruntime that referenced this issue Apr 4, 2023
…LLY_DISCONNECTED=ON` (#15323)

### Description
Rework some external targets to ease building with
`-DFETCHCONTENT_FULLY_DISCONNECTED=ON`
This will allow package managers to more easily provide an onnxruntime
package by reducing the amount of patching needed downstream at each
version.

### Motivation and Context
Availability of onnxruntime in some C++ package managers
#7150
conan-io/conan-center-index#16699
microsoft/vcpkg#20548

My initial intent is to get this in conan but the PR would most likely
be useful (though not tested) to vcpkg as well (and maybe others).
I tried to get only a first batch of not too specific patches (i.e. not
specific to conan).

The first commit reworks `flatbuffers` and just extends what @snnn did
in #13991
The second commit reworks `pytorch_cpuinfo`
The third commit reworks `google_nsync`
adityagoel4512 pushed a commit to adityagoel4512/onnxruntime that referenced this issue Apr 5, 2023
…LLY_DISCONNECTED=ON` (microsoft#15323)

### Description
Rework some external targets to ease building with
`-DFETCHCONTENT_FULLY_DISCONNECTED=ON`
This will allow package managers to more easily provide an onnxruntime
package by reducing the amount of patching needed downstream at each
version.

### Motivation and Context
Availability of onnxruntime in some C++ package managers
microsoft#7150
conan-io/conan-center-index#16699
microsoft/vcpkg#20548

My initial intent is to get this in conan but the PR would most likely
be useful (though not tested) to vcpkg as well (and maybe others).
I tried to get only a first batch of not too specific patches (i.e. not
specific to conan).

The first commit reworks `flatbuffers` and just extends what @snnn did
in microsoft#13991
The second commit reworks `pytorch_cpuinfo`
The third commit reworks `google_nsync`
@Dr-Electron
Copy link
Contributor

@JackBoosY would it now make sense to work on top of your work in #23768 again. I wrote down that I have to wait for cccl 2.2.0. But tbh I don't remeber why. Probably because they planed for that version to contain all migrated repos like cub and so on. And now they are at version 2.3. Maybe worth a try again ❤️ . I would offer to help, but I probably wouldn't be of much use 😅

@horenmar
Copy link
Contributor Author

There is an in-progress PR for from-source build at #36850

@luncliff luncliff linked a pull request Mar 24, 2024 that will close this issue
13 tasks
@cjsdurj
Copy link

cjsdurj commented Jul 5, 2024

hi. beside cpu & cuda EP , other onnxruntime EPs may also needed , such as : openvino ( inference onnx model in intel npu .) directml ( microsoft developed and can support many types of gpu: nvidia , amd, intel ... ) ;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
7 participants