[cmake] Fix target onnxruntime_providers_cuda installation path #11136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @snnn |
snnn
reviewed
Apr 7, 2022
| @@ -502,7 +502,7 @@ if (onnxruntime_USE_CUDA) | |||
|
|
|||
| install(TARGETS onnxruntime_providers_cuda | |||
| ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} | |||
| LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} | |||
| LIBRARY DESTINATION ${CMAKE_INSTALL_BINDIR} | |||
There was a problem hiding this comment.
Does it mean on Linux it will be installed to /usr/local/bin instead of /usr/local/lib ?
There was a problem hiding this comment.
Yeah, I can add some code, wait for a while.
|
RFC |
|
Ah this PR is too old, I can close this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Describe your changes.
The target
onnxruntime_providers_cudashould always be built as dynamic and be used with dynamic load.So the installation path should be
CMAKE_INSTALL_BINDIRinstead ofCMAKE_INSTALL_LIBDIR.Fix that.
Motivation and Context