Add experimental retro terminal effects #3468

ironyman · 2019-11-07T06:37:56Z

Summary of the Pull Request

Cool retro terminal effects

glow
scan lines
cool
will make terminal competitive with iterm2

References

PR Checklist

Closes #xxx
CLA signed. If not, go over here and sign the CLA
Tests added/passed
Requires documentation to be updated
I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

mdtauk · 2019-11-07T06:51:11Z

Maybe this kind of "visual effect" could become an extension in the future, so others can "plug-in" their own effects or shaders for Windows Terminal

zadjii-msft · 2019-11-07T13:21:05Z

Oh my god this is so much fun.

I do like the idea that this might be a good type of extension. I'll discuss with the team, but this might be complete enough that we'd want to ship it with the Terminal (at least for 1.0). However, I definitely wouldn't feel comfortable merging this without hiding it behind a setting (probably per-profile) to make it optional.

miniksa · 2019-11-07T17:30:28Z

OK I love it. I want it in. @zadjii-msft, we should make a list of things that could be pulled into extensions in the future (this, azure cloud shell, etc.) to make them easier to update/swap. But I don't think we should be gating cool and interesting functionality on the lack of an extension framework for v1.0.

miniksa · 2019-11-07T17:35:02Z

@ironyman, are you in any way related to /u/1r0nyman who "YOLO"d his way through box spreads on /r/wallstreetbets or is this just a coincidence?

miniksa

Excellent idea. We're also going to need some configuration plumbed through of course. I left a batch of comments on how it's gone so far.

src/renderer/dx/DxRenderer.cpp

src/renderer/base/renderer.cpp

miniksa · 2019-11-07T17:43:27Z

src/renderer/dx/DxRenderer.cpp

+}
+)";
+
+const char _pixelShaderString[] = R"(


I haven't done shaders before, in earnest, but isn't there a resource file type that shader code can be placed into and loaded instead of writing it as giant const strings in the source?

I can move this to an .hlsl file that's built by visual studio. But how do I make sure the output is packaged with application so the application can find the compiled shader output at runtime?

Does it not carry it automatically? I would think that adding a supported compilation thing should be carried through into the binaries and into the package. We might have to page @DHowett-MSFT if it isn't automatic.

Nope

C:\Users\changyl\Documents\GitHub\terminal\src\renderer\dx\DxRenderer.cpp(211)\TerminalControl.dll!00007FF87A823678: (caller: 00007FF87A822E1C) ReturnHr(4) tid(3150) 80070002 The system cannot find the file specified. [Microsoft::Console::Render::DxEngine::_SetupTerminalEffects(D3DReadFileToBlob(L"ScreenVertexShader.cso", &vertexBlob))]

PS C:\Users\changyl\Documents\GitHub\terminal> gci -Recurse -Filter "ScreenPixel*" Directory: C:\Users\changyl\Documents\GitHub\terminal\bin\x64\Debug Mode LastWriteTime Length Name ---- ------------- ------ ---- -a---- 11/8/2019 10:18 PM 30340 ScreenPixelShader.cso Directory: C:\Users\changyl\Documents\GitHub\terminal\src\renderer\dx\lib Mode LastWriteTime Length Name ---- ------------- ------ ---- -a---- 11/8/2019 10:10 PM 3563 ScreenPixelShader.hlsl

Dustin said that the only way to package it into the UWP app right now is to put the hlsl files into another project. That's going to be kind of messy so he said he's OK with leaving it in the source code for now and fixing it later. What do you think?

Yea I think I'm okay with that, but let's compromise by defining the strings in some other header file and including them here. Does that sound reasonable?

src/renderer/dx/DxRenderer.cpp

src/renderer/vt/paint.cpp

src/renderer/base/renderer.cpp

src/renderer/dx/DxRenderer.cpp

ironyman · 2019-11-08T04:08:55Z

@ironyman, are you in any way related to /u/1r0nyman who "YOLO"d his way through box spreads on /r/wallstreetbets or is this just a coincidence?

God I wish

zadjii-msft

I don't really understand the DX-y bits, but I do understand that this is awesome.

Fundamentally, my only concern with this is that I'd like to have a setting in the terminal that enables/disables this mode. Doesn't need to be anything complicated, probably just a boolean setting in Profile and IControlSettings that's something like "retroTerminalEffect". Get the profile to deserialize that, pass it to the TerminalSettings, and have TermControl set some property on the DxEngine to enable this. #3471 was just completed that does something very similar.

src/renderer/dx/DxRenderer.cpp

zadjii-msft · 2019-11-13T21:33:53Z

src/renderer/dx/DxRenderer.cpp

+    return 0;
+}
+
+Microsoft::WRL::ComPtr<ID3DBlob>


We should maybe move this to some sort of DxUtils.h/cpp file... @miniksa thoughts?

src/renderer/dx/DxRenderer.cpp

zadjii-msft · 2019-11-13T21:52:38Z

Also, make sure to run tools\runformat from the root of the solution to have it fix the formatting check. If that causes the formatting on the shader strings to explode, you can always wrap them with // clang-format off and // clang-format on.

zadjii-msft

Largely I think I'm okay with this. I'm not going to sign off quite yet since I left a bunch of nits, but nothing really worth blocking on. Two other people on the team can feel free to override me :)

Let's get @miniksa in here to review this as well.

zadjii-msft · 2019-11-19T14:22:46Z

src/host/exe/Host.EXE.vcxproj

@@ -84,8 +84,9 @@
    </ClCompile>
    <Link>
      <AllowIsolation>true</AllowIsolation>
+      <AdditionalDependencies>d3dcompiler.lib</AdditionalDependencies>


There's probably a better place to put this, @miniksa knows where.

(this one is still here too)

zadjii-msft · 2019-11-19T14:24:49Z

src/renderer/dx/ScreenPixelShader.h

+{
+    Texture2D input = shaderTexture;
+
+    // TODO Make these configurable in some way.


I can go through and file follow-up tasks for this

zadjii-msft · 2019-11-19T14:25:12Z

src/renderer/dx/ScreenPixelShader.h

+{
+    float wave = SquareWave(pos.y);
+
+    // TODO make this configurable.


(we'll also want a follow-up on this one)

src/renderer/dx/DxRenderer.cpp

zadjii-msft · 2019-11-19T14:29:43Z

src/cascadia/TerminalControl/TermControl.cpp

@@ -484,6 +484,8 @@ namespace winrt::Microsoft::Terminal::TerminalControl::implementation
        // Tell the DX Engine to notify us when the swap chain changes.
        dxEngine->SetCallback(std::bind(&TermControl::SwapChainChanged, this));

+        dxEngine->SetRetroTerminalEffects(_settings.RetroTerminalEffect());


We probably also want to do this in UpdateSettings, so that changing the setting will hot-reload the setting

Can we make a task for this? We would need to do setup outside of normal dxEngine setup path to support hot reloading.

Oh, that's a good point. I can make that follow-up

src/renderer/dx/DxRenderer.cpp

zadjii-msft · 2019-11-19T14:42:22Z

src/renderer/dx/DxRenderer.cpp

+    // Prepare shaders.
+    auto vertexBlob = _CompileShader(screenVertexShaderString, "vs_5_0");
+    auto pixelBlob = _CompileShader(screenPixelShaderString, "ps_5_0");
+    // TODO: move the shader files to to hlsl files and package their


we should file a follow-up task for this

src/renderer/dx/DxRenderer.cpp

Huh, I thought commenting would clear my block. Apparently it doesn't.

DHowett-MSFT

Okay, I love this. It is beautifully well-contained, non-intrusive, opt-in, and has good error handling. I love it to bits. Thank you.

One thing I'd like to request in addition to my couple of comments is that we (sorry, I know you had to do this once already) rename the setting.

Eventually, we will replace this with configurable shaders with, perhaps, configurable shader inputs. We're not quite there yet, of course, as you can well see. When we are, though, the option will look quite different from Profile::retroTerminalEffects.

To clue users into the fact that their cheese might move, and somewhat secure us against their complaints, can we call the JSON key experimental.retroTerminalEffects? (If @zadjii-msft doesn't like the ., we can use _, but this seems nicely namespaced)

DHowett-MSFT · 2019-12-04T02:28:16Z

src/cascadia/PublicTerminalCore/PublicTerminalCore.vcxproj

  <ItemDefinitionGroup>
    <ClCompile>
      <PrecompiledHeaderFile>pch.h</PrecompiledHeaderFile>
    </ClCompile>
+    <Link>
+      <AdditionalDependencies>d3dcompiler.lib</AdditionalDependencies>


nit: You may just want to add this to the common link line in common.pre.props

DHowett-MSFT · 2019-12-04T02:31:36Z

src/renderer/dx/DxRenderer.cpp

+
+            if (_retroTerminalEffects)
+            {
+                const HRESULT hr = _SetupTerminalEffects();


Does this need an operating system version guard? the WPF terminal control wants to work on Windows 7.

I don't think there's any dependency on OS version. Just directx which the terminal already depends on.

src/renderer/dx/DxRenderer.cpp

oising · 2019-12-05T01:28:36Z

Wow, beautiful work @ironyman !

src/common.build.pre.props

DHowett-MSFT · 2019-12-10T02:04:26Z

src/renderer/dx/DxRenderer.cpp

@@ -1060,6 +1050,16 @@ void DxEngine::_InvalidOr(RECT rc) noexcept
 // - S_OK on success, E_PENDING to indicate a retry or a relevant DirectX error
 [[nodiscard]] HRESULT DxEngine::Present() noexcept
 {
+    if (_retroTerminalEffects)


Awesome! I bet this makes io feel a little faster since we're not doing computation under console-lock.

ironyman · 2019-12-10T03:50:54Z

I tried rebasing but it's giving me a lot of these errors

2>DynamicProfileTests.cpp
2>C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\WindowsNumerics.impl.h(49,5): error C2011: 'winrt::Windows::Foundation::Numerics::float2': 'struct' type redefinition (compiling source file DynamicProfileTests.cpp)
2>C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\WindowsNumerics.impl.h(39): message : see declaration of 'winrt::Windows::Foundation::Numerics::float2' (compiling source file DynamicProfileTests.cpp)
2>C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\WindowsNumerics.impl.h(118,5): error C2011: 'winrt::Windows::Foundation::Numerics::float3': 'struct' type redefinition (compiling source file DynamicProfileTests.cpp)
2>C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\WindowsNumerics.impl.h(40): message : see declaration of 'winrt::Windows::Foundation::Numerics::float3' (compiling source file DynamicProfileTests.cpp)
2>C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\WindowsNumerics.impl.h(179,5): error C2011: 'winrt::Windows::Foundation::Numerics::float4': 'struct' type redefinition (compiling source file DynamicProfileTests.cpp)
2>C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\WindowsNumerics.impl.h(41): message : see declaration of 'winrt::Windows::Foundation::Numerics::float4' (compiling source file DynamicProfileTests.cpp)
2>C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\WindowsNumerics.impl.h(243,5): error C2011: 'winrt::Windows::Foundation::Numerics::float3x2': 'struct' type redefinition (compiling source file DynamicProfileTests.cpp)
2>C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\WindowsNumerics.impl.h(42): message : see declaration of 'winrt::Windows::Foundation::Numerics::float3x2' (compiling source file DynamicProfileTests.cpp)
2>C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\WindowsNumerics.impl.h(299,5): error C2011: 'winrt::Windows::Foundation::Numerics::float4x4': 'struct' type redefinition (compiling source file DynamicProfileTests.cpp)
2>C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\WindowsNumerics.impl.h(43): message : see declaration of 'winrt::Windows::Foundation::Numerics::float4x4' (compiling source file DynamicProfileTests.cpp)
2>C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\WindowsNumerics.impl.h(376,5): error C2011: 'winrt::Windows::Foundation::Numerics::plane': 'struct' type redefinition (compiling source file DynamicProfileTests.cpp)

zadjii-msft · 2019-12-11T15:20:10Z

@ironyman woah that's a crazy compilation error. I honestly don't know what's causing that - I'll check out your branch locally and try and merge it up to master and figure it out.

zadjii-msft · 2019-12-11T17:39:42Z

@ironyman Okay so I just checked this branch out and merged master in, one release at a time. I haven't seen that error message at all unfortunately :/ You can check my version out in dev/migrie/merge-3468-and-master.

I bet if you do a clean rebuild, it'll probably go away.

I might also try navigating to the x64\Debug directory, and running del /s /q *.winmd, then rebuilding. Sometimes msbuild is really bad at cleaning outdated winmds, causing rebuilding to fail.
MAKE SURE to NOT do that in the root of the solution, it'll delete winmds for nuget packages and then the whole solution will get really confused.

## Summary of the Pull Request The original PR had a few TODOs in it without issue numbers. IMO, this wasn't important enough to block the PR over. _Also I'm impatient and wanted that setting_. After I merged the PR I created the issues and added the numbers myself. ## References ## PR Checklist * [x] Closes nothing, this just adds a couple TODOs * [x] I work here * [x] this _really_ doesn't need tests * [x] This _is_ a docs update

ghost · 2020-01-14T17:16:58Z

🎉Windows Terminal Preview v0.8.10091.0 has been released which incorporates this pull request.:tada:

Handy links:

marcinsmialek · 2020-01-14T21:50:01Z

It's more fun than I expected

fredswims · 2020-01-15T02:23:47Z

Don't understand how you choose the effect; glow, scan lines, cool. Using "experimental.retroTerminalEffect": true seems to set the effect to scan lines.

DHowett-MSFT · 2020-01-15T02:24:56Z

You don’t. It’s just one effect that has all three of those things. It glows, has scan lines, and is cool.

fredswims · 2020-01-15T02:27:23Z

Silly me. Thank you.

oskaremil · 2020-01-15T06:51:06Z

I dont get it. I enabled the feature. See no difference

zadjii-msft · 2020-01-15T14:27:03Z

@oskaremil If you're having a problem with the Terminal, you should probably search our list of issues to see if anyone else has the same problem as you. If not, could you file a new issue, so we can track and diagnose your issue specifically?

richardthombs · 2020-01-15T19:56:27Z

Can't believe any of the CRTs I worked on ever looked this bad!

DHowett-MSFT · 2020-01-15T19:57:29Z

I can't tell if you're being sarcastic or mean, so:

if...
sarcastic: we got the dirtiest old CRT with alignment issues that we could as a model
mean: hey now.

richardthombs · 2020-01-15T20:10:17Z

Not mean! Nonono. I would love to use this for some of my long running console jobs, but it is right on the edge of tolerable. Are the effects tweakable at all, or is it all in the shaders?

DHowett-MSFT · 2020-01-15T20:50:08Z

Alas! It's all in the shaders, and those aren't yet configurable.

mlindgren · 2020-01-16T01:03:28Z

@oskaremil Make sure to open a new tab after enabling the effect. I don't think hot-reload works with this, probably because of how the shader is loaded.

fredswims · 2020-01-16T06:42:58Z

If/when the hot-reload works, it would be a hoot to set the property via a keystroke.

oskaremil · 2020-01-17T06:52:37Z

@oskaremil Make sure to open a new tab after enabling the effect. I don't think hot-reload works with this, probably because of how the shader is loaded.

I did. Will open a new issue for this.

BalintFarkas · 2020-01-17T07:39:38Z

Very cool, loving it! But as @richardthombs said some configurability would be nice as this markedly decreases legibility. Leaving it on anyway! :)

danny506 · 2020-01-19T21:29:04Z

I dont get it. I enabled the feature. See no difference

@oskaremil I also did not see any difference, but after a few minutes I figured out that "experimental.retroTerminalEffect": true has to be placed inside of a profile object in profiles.json.

venimus · 2020-01-20T08:05:47Z

So you added a d3d (dx11) dependancy for this feature, that everybody turns off after 10 seconds and never use it again?

DHowett-MSFT · 2020-01-20T08:26:14Z

@venimus perhaps there’s a nicer way to get your message across?

venimus · 2020-01-20T10:56:53Z

Sorry but this is my nicer way. IMHO this feature is even less useful than that. There are already fonts that include the scanlines effect (although not affecting the background).

However being already there, you could improve the nostalgia filter further:

Add chromatic aberration
Add glow
Add some lens distortion

eg: http://www.mclelun.com/2018/10/after-effects-vintage-terminal-console.html

pedrolamas · 2020-01-23T15:45:17Z

It seems to ignore the Display Scaling set in Windows Settings.

This is what I get on a Dell 1080p external monitor set to 100% scaling:

And this is what I get on my Dell XPS 15 laptop with a 4k screen set to 200% scaling:

As you can see, the effect on the 200% scaled monitor is barely noticeable!

BalintFarkas · 2020-01-23T15:59:30Z

So you added a d3d (dx11) dependancy for this feature, that everybody turns off after 10 seconds and never use it again?

I turned it on the day it came out and been using it ever since. For hours every day. Apparently, there's no accounting for taste.

drewnoakes · 2020-01-24T11:09:04Z

doc/cascadia/profiles.schema.json

+        "retroTerminalEffect": {
+          "description": "When set to true, enable retro terminal effects.",
+          "type": "boolean"
+        }


Should be a comma here.

Looks like this was already fixed

terminal/doc/cascadia/profiles.schema.json

Lines 535 to 538 in 82f302b

"experimental.retroTerminalEffect": {

"description": "When set to true, enable retro terminal effects. This is an experimental feature, and its continued existence is not guaranteed.",

"type": "boolean"

},

zipponator · 2020-02-11T15:33:39Z

@ironyman this is so great! thank you!! I've been using it since i heard about it, with #00FF00 on all colors for the old monochrome green look :)

I have the same experience as @pedrolamas though, on a screen with scaling effect it's barely noticeable (i have 300%, so even harder to see). I went down a rabbit-hole of thinking it was the GPU acceleration that was turned off on the laptop monitor but not on the external monitor, but it is indeed the scaling that makes it do the scan lines really tight.

zipponator · 2020-02-11T20:45:14Z

For reference, here's one word zoomed in 6x.

## Summary of the Pull Request - Scale the retro terminal effects (#3468) scan lines with the screen's DPI. - Remove artifacts from sampling wrap around. Before & after, with my display scale set to 350%: ![Scaling scan lines](https://user-images.githubusercontent.com/38924837/75214566-df0f4780-5742-11ea-9bdc-3430eb24ccca.png) Before & after showing artifact removal, with my display scale set to 100%, and image enlarged to 400%: ![Sampling artifacts annotated](https://user-images.githubusercontent.com/38924837/75214618-05cd7e00-5743-11ea-9060-f4eba257ea56.png)  ## PR Checklist * [x] Closes #4362 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx  ## Detailed Description of the Pull Request / Additional comments Adds a constant buffer, which could be used for other settings for the retro terminal pixel shader. I haven't touched C++ in over a decade before this change, and this is the first time I've played with DirectX, so please assume my code isn't exactly best practice. 🙂  ## Validation Steps Performed - Changed display scale with experimental.retroTerminalEffect enabled, enjoyed scan lines on high resolution monitors. - Enabled experimental.retroTerminalEffect, turned the setting off, changed display scale. Retro tabs still scale scan lines.

xan2622 · 2020-05-20T06:59:03Z

Thank you for these effects. 👍 They remind me of this other project: Cool Retro Term.
https://github.com/Swordfish90/cool-retro-term

zadjii-msft added Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Product-Terminal The new Windows Terminal. labels Nov 7, 2019

miniksa reviewed Nov 7, 2019

View reviewed changes

zadjii-msft previously requested changes Nov 13, 2019

View reviewed changes

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 13, 2019

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 19, 2019

ironyman force-pushed the shader3 branch 3 times, most recently from a03cf64 to 61d703b Compare November 19, 2019 03:30

zadjii-msft reviewed Nov 19, 2019

View reviewed changes

zadjii-msft requested a review from miniksa November 25, 2019 15:01

DHowett-MSFT suggested changes Dec 4, 2019

View reviewed changes

ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Dec 4, 2019

WSLUser mentioned this pull request Dec 9, 2019

Strawman: Dumb implementation of text D2D effects. #817

Closed

DHowett-MSFT reviewed Dec 10, 2019

View reviewed changes

q added 2 commits December 11, 2019 12:01

Glow works

608d6af

Fix bad search and replace

d74cfdc

drewnoakes reviewed Jan 24, 2020

View reviewed changes

This was referenced Feb 11, 2020

Scenario: Add support for 3rd-party extensions #4000

Open

Glow text exploration #781

Closed

dotpaul mentioned this pull request Feb 25, 2020

Scale retro terminal scan lines #4716

Merged

5 tasks

This pull request was closed.

	"experimental.retroTerminalEffect": {
	"description": "When set to true, enable retro terminal effects. This is an experimental feature, and its continued existence is not guaranteed.",
	"type": "boolean"
	},

Add experimental retro terminal effects #3468

Add experimental retro terminal effects #3468

Conversation

ironyman commented Nov 7, 2019 • edited Loading

Summary of the Pull Request

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

mdtauk commented Nov 7, 2019

zadjii-msft commented Nov 7, 2019

miniksa commented Nov 7, 2019

miniksa commented Nov 7, 2019

miniksa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ironyman Nov 9, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ironyman commented Nov 8, 2019

zadjii-msft left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zadjii-msft commented Nov 13, 2019

zadjii-msft left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DHowett-MSFT left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oising commented Dec 5, 2019

Choose a reason for hiding this comment

ironyman commented Dec 10, 2019

zadjii-msft commented Dec 11, 2019

zadjii-msft commented Dec 11, 2019

ghost commented Jan 14, 2020

marcinsmialek commented Jan 14, 2020

fredswims commented Jan 15, 2020

DHowett-MSFT commented Jan 15, 2020

fredswims commented Jan 15, 2020

oskaremil commented Jan 15, 2020

zadjii-msft commented Jan 15, 2020

richardthombs commented Jan 15, 2020

DHowett-MSFT commented Jan 15, 2020

richardthombs commented Jan 15, 2020

DHowett-MSFT commented Jan 15, 2020

mlindgren commented Jan 16, 2020

fredswims commented Jan 16, 2020

oskaremil commented Jan 17, 2020

BalintFarkas commented Jan 17, 2020 • edited Loading

danny506 commented Jan 19, 2020

venimus commented Jan 20, 2020 • edited Loading

DHowett-MSFT commented Jan 20, 2020

venimus commented Jan 20, 2020

pedrolamas commented Jan 23, 2020 • edited Loading

BalintFarkas commented Jan 23, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zipponator commented Feb 11, 2020

zipponator commented Feb 11, 2020

xan2622 commented May 20, 2020

ironyman commented Nov 7, 2019 •

edited

Loading

ironyman Nov 9, 2019 •

edited

Loading

BalintFarkas commented Jan 17, 2020 •

edited

Loading

venimus commented Jan 20, 2020 •

edited

Loading

pedrolamas commented Jan 23, 2020 •

edited

Loading