Add Selection Background Color as a setting to Profiles and Col…

[leonMSFT]

Summary of the Pull Request

This introduces a setting to both Profiles and ColorSchemes called selectionBackground that allows you to change the selection background color to what's specified. If selectionBackground isn't set in either the profile or color scheme, it'll default to what it was before - white.

PR Checklist

• Closes Add a setting to control selection background color #3326
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed
• Requires documentation to be updated

Validation Steps Performed

• Added selectionBackground to existing profile and colorscheme tests.
• Verified that the color does change to what I expect it to be when I add "selectionBackground" to either/both a profile and a color scheme.

[mdtauk]

Is there already a SelectionForeground colour?

[leonMSFT]

@mdtauk Nope! There is not currently a setting for SelectionForeground.

[zadjii-msft]

This definitely looks good. Setting is plumbed through all the places it needs to be plumbed through.

Though, maybe it makes more sense to just have this be a property on the DxEngine, and not necessarily a part of TerminalCore. Maybe the setting should be moved to IControlSettings, and just set a property of the DxRenderer, instead of needing to plumb it all the way down to the TerminalCore and having it then tell the renderer each frame what the BG color should be. Further, then each of the other engines wouldn't need to have that added param on their PaintSelection methods. Plus, conhost wouldn't need to implement anything special at all to handle this, it would just leave the value unchanged (with a default of DEFAULT_FOREGROUND). Thoughts?

[leonMSFT]

@zadjii-msft Thanks for the suggestions! Putting the setting in IControlSettings and letting TermControl update the color in DxEngine really cut down on the amount of files I needed to touch.

[zadjii-msft]

I believe this is all okay except for that one _selectionBackground thing.

[javierdlg]

Thanks for the quick turnaround!

[ghost]

🎉Windows Terminal Preview v0.7.3291.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download