Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glow text exploration #781

Closed
miniksa opened this issue May 14, 2019 · 5 comments
Closed

Glow text exploration #781

miniksa opened this issue May 14, 2019 · 5 comments
Labels
Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal Backlog

Comments

@miniksa
Copy link
Member

miniksa commented May 14, 2019

OK. The glow text example I gave that's currently inside the code (but unused) isn't great.

I've received feedback from @MilesMSCohen that it has a fundamental flaw:

  • It loses all font hinting which makes it hard to read, especially at small sizes.

Ouch. I want hinting. The recommended alternative is to render the text to a command list and use the command list as input to an effect that can cause a glow.

@DHowett-MSFT already had a sample lump of code to do something like this that he was playing around with a few weeks ago because glow text is cool. It's around here somewhere.

Also, I got the warning from @MilesMSCohen that this might have worse performance, but we'd have to decide if that's worth it.
@miniksa miniksa added the Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues label May 14, 2019
@miniksa
Copy link
Member Author

miniksa commented May 14, 2019

This may be a duplicate of #621. I'm just putting all my internal notes/bugs into GitHub.

@MilesMSCohen
Copy link

MilesMSCohen commented May 14, 2019 via email

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@miniksa miniksa added Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Mass-Chaos labels May 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Jun 19, 2019
@zadjii-msft zadjii-msft added the Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. label Jun 19, 2019
@weswigham
Copy link
Member

I'd love for the ability to declare glow parameters for text of specific colors (rather than for all text or none), mostly just to complete a synthwave terminal theme.

@zadjii-msft zadjii-msft mentioned this issue Dec 17, 2019
Open
8 tasks
@WSLUser
Copy link
Contributor

WSLUser commented Feb 11, 2020

#3468 added glow effects. Not sure if your original code was replaced in the process (but most likely). But this issue may be fixed already.

@zadjii-msft
Copy link
Member

You know, with custom shaders (#7013), I don't think we really need to re-explore this. Let's just let folks do their own shader thing, that's been pretty dang flexible so far.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal Backlog
Development

No branches or pull requests
5 participants
@weswigham @miniksa @zadjii-msft @WSLUser @MilesMSCohen