Switch FAIL_FAST to LOG for starting inbound connection server on monarch startup #10261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…connections, but still crash when COM attempted to start us
ghost
added
Area-DefApp
Priority-1
zadjii-msft
approved these changes
May 28, 2021
You know exactly what I'm going to say here. |
DHowett
approved these changes
May 28, 2021
|
@msftbot merge this in 2 minutes |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
DHowett
added
the
zPreview-Service-Queued-1.13
DHowett
changed the title
ghost
merged commit 
DHowett
pushed a commit
that referenced
this pull request
Jun 1, 2021
…arch startup (#10261) Stop startup crash by logging when monarch fails to register inbound connections, but still crash when COM attempted to start us ## References - See also #10243 ## PR Checklist * [x] Closes #10233 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA ## Detailed Description of the Pull Request / Additional comments - This should stop the crash on launch until we can get the internal teams to resolve the catalog issue - I left the COM -Embedding start fail fast though so it won't take forever to time out (as default timeout is 3-5 minutes). I will change that if it becomes necessary. ## Validation Steps Performed - I basically have to guess at this one based on the crash dump and Watson logs because it happens sporadically when the platform messes up on us. (cherry picked from commit d8647e0)
DHowett
removed
the
zPreview-Service-Queued-1.13
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop startup crash by logging when monarch fails to register inbound connections, but still crash when COM attempted to start us
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed