-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash on startup, related to defterm #10233
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Oh no I tried reproing this with the debugger attached to the launch of the Terminal, so I could breakpoint immediately. Guess what, the problem went away, and now it's no longer hitting at all. Like it won't repro even without the debugger. Shoot. I'm a tad worried that the package was somehow busted and launching with the debugger made the OS just sort it's shit out. But no way to know now 😕 Niksa said he'd take a look at the dump though, so I'll leave this open for him. I don't think there's anything valuable in it, considering we're in the |
It also looks like this is (failure?) 13cbe5b8-092a-28b2-3256-509530451824 in watson. So it's definitely real. |
How to find the real exception from a wil fail fast:
That Exception Code looks like non-sense. They usually start with Param 4:
Yeah that looks like nothing. Param 6:
Jackpot.
OK so it's a
HEY-O. That feels almost reasonable. Clicky through on
OK so Clicky through on
Clicky through on
And it looks like we are almost in business. Now to figure out how to decode this... |
This particular line ended up a dead end. Doing Except with @zadjii-msft identifying the Watson bucket This shouldn't have happened. But... we need to transfer this issue internally to have the platform teams figure out why. I will link this to #10243 as a main bug because there are several others related that look like the same version sharding cause. |
(In this bug, I will remove the fail fast, turning it into a log statement instead, and defapp just won't work until you start another session. Better than crashing but mildly unsatisfying. Also should only happen when new versions are pushed which isn't every day.) |
See internal MSFT:33501832 |
…arch startup (#10261) Stop startup crash by logging when monarch fails to register inbound connections, but still crash when COM attempted to start us ## References - See also #10243 ## PR Checklist * [x] Closes #10233 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA ## Detailed Description of the Pull Request / Additional comments - This should stop the crash on launch until we can get the internal teams to resolve the catalog issue - I left the COM -Embedding start fail fast though so it won't take forever to time out (as default timeout is 3-5 minutes). I will change that if it becomes necessary. ## Validation Steps Performed - I basically have to guess at this one based on the crash dump and Watson logs because it happens sporadically when the platform messes up on us.
…arch startup (#10261) Stop startup crash by logging when monarch fails to register inbound connections, but still crash when COM attempted to start us ## References - See also #10243 ## PR Checklist * [x] Closes #10233 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA ## Detailed Description of the Pull Request / Additional comments - This should stop the crash on launch until we can get the internal teams to resolve the catalog issue - I left the COM -Embedding start fail fast though so it won't take forever to time out (as default timeout is 3-5 minutes). I will change that if it becomes necessary. ## Validation Steps Performed - I basically have to guess at this one based on the crash dump and Watson logs because it happens sporadically when the platform messes up on us. (cherry picked from commit d8647e0)
🎉This issue was addressed in #10261, which has now been successfully released as Handy links: |
🎉This issue was addressed in #10261, which has now been successfully released as Handy links: |
Microsoft.WindowsTerminalPreview_1.9.1445.0
, internal OS buildWe're hitting the
CATCH_FAIL_FAST
:Dump is in
c:\users\migrie\dev\startup-crash.dmp
. Repo's been hot yesterday so this might have already been filed - I'll dedupe later.stack
The text was updated successfully, but these errors were encountered: