Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSIX version tearing causes instability and crashes #10243

Open
miniksa opened this issue May 27, 2021 · 3 comments
Open

MSIX version tearing causes instability and crashes #10243

miniksa opened this issue May 27, 2021 · 3 comments
Labels
Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Culprit-Centennial Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Tracking-External This bug isn't resolved, but it's following an external workitem.

Comments

@miniksa
Copy link
Member

miniksa commented May 27, 2021

This bug represents a class of issues with the MSIX platform running mixed versions of our package at the same time. This violates fundamental assumptions of our code and causes instability and crashing in a variety of ways.
We are pursuing this issue internally with the MSIX platform, but this main bug will represent any other issues that get root-caused to this situation.
@miniksa miniksa added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. Tracking-External This bug isn't resolved, but it's following an external workitem. labels May 27, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 27, 2021
@miniksa miniksa mentioned this issue May 27, 2021
Closed
@miniksa
Copy link
Member Author

miniksa commented May 27, 2021 •
edited
Loading

OOP COM Server object activation tearing - MSFT:33501832
AppExecutionAlias pointing to wrong version after upgrade (Old EXE running with new DLLs inside) - MSFT:31709999 - Resolved

This was referenced May 27, 2021
Closed
Closed
@zadjii-msft
Copy link
Member

Terminal - unable to find the selected font error at startup - MSFT:32337657 was also sorta related to this. That was the font bug that I think we tried working around. The workaround is now causing #10211. That's less about a torn state, and more about a botched upgrade.

@zadjii-msft zadjii-msft mentioned this issue May 28, 2021
Closed
@miniksa miniksa mentioned this issue May 28, 2021
Merged
2 tasks
ghost pushed a commit that referenced this issue May 28, 2021
@miniksa
Switch FAIL_FAST to LOG for starting inbound connection server on mon…
d8647e0 
…arch startup (#10261)

Stop startup crash by logging when monarch fails to register inbound connections, but still crash when COM attempted to start us

## References
- See also #10243 

## PR Checklist
* [x] Closes #10233
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA

## Detailed Description of the Pull Request / Additional comments
- This should stop the crash on launch until we can get the internal teams to resolve the catalog issue
- I left the COM -Embedding start fail fast though so it won't take forever to time out (as default timeout is 3-5 minutes). I will change that if it becomes necessary.

## Validation Steps Performed
- I basically have to guess at this one based on the crash dump and Watson logs because it happens sporadically when the platform messes up on us.
@miniksa miniksa removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 28, 2021
@miniksa
Copy link
Member Author

miniksa commented May 28, 2021

OOP COM Server object activation tearing - MSFT:33501832

This is being investigated internally, but this question was proposed internally. If anyone is seeing this and willing to capture this data, please let us know so we can connect you with the platform team investigators:

"If you encounter this can you export the contents of HKCU\Software\Classes\PackagedCom? I want to check the pattern against what I see on my machine."

@miniksa miniksa mentioned this issue May 28, 2021
Closed
@zadjii-msft zadjii-msft mentioned this issue Jun 1, 2021
Closed
DHowett pushed a commit that referenced this issue Jun 1, 2021
@miniksa @DHowett
Switch FAIL_FAST to LOG for starting inbound connection server on mon…
414adf1 
…arch startup (#10261)

Stop startup crash by logging when monarch fails to register inbound connections, but still crash when COM attempted to start us

## References
- See also #10243

## PR Checklist
* [x] Closes #10233
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA

## Detailed Description of the Pull Request / Additional comments
- This should stop the crash on launch until we can get the internal teams to resolve the catalog issue
- I left the COM -Embedding start fail fast though so it won't take forever to time out (as default timeout is 3-5 minutes). I will change that if it becomes necessary.

## Validation Steps Performed
- I basically have to guess at this one based on the crash dump and Watson logs because it happens sporadically when the platform messes up on us.

(cherry picked from commit d8647e0)
@DHowett DHowett mentioned this issue Jun 8, 2021
Closed
@zadjii-msft zadjii-msft mentioned this issue Feb 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Culprit-Centennial Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Tracking-External This bug isn't resolved, but it's following an external workitem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miniksa @zadjii-msft